Opened 6 months ago
Closed 5 months ago
#34060 closed enhancement (fixed)
Height function for polynomials on number fields
Reported by:  Jing Guo  Owned by:  

Priority:  major  Milestone:  sage9.7 
Component:  algebra  Keywords:  gsoc2022 
Cc:  Ben Hutz, Alexander Galarraga  Merged in:  
Authors:  Jing Guo, Ben Hutz  Reviewers:  Alexander Galarraga 
Report Upstream:  N/A  Work issues:  
Branch:  ad991a3 (Commits, GitHub, GitLab)  Commit:  ad991a3875175e78e274c3fd01aa00d3a19d194c 
Dependencies:  Stopgaps: 
Description (last modified by )
As suggested in #33971, a new ticket for height function for polynomials on number fields is created.
We want to define the global absolute height function for polynomials.
Change History (19)
comment:1 Changed 6 months ago by
Description:  modified (diff) 

comment:2 Changed 6 months ago by
Commit:  0d582710e18af55d4c7b3626a12237e322a80647 → 0b4dd00508d2df4c99c519fd9f968e190ff0bdf0 

comment:3 Changed 5 months ago by
Branch:  u/ghguojing0/33971_dyn_sys_height → u/ghguojing0/34060_poly_height 

Commit:  0b4dd00508d2df4c99c519fd9f968e190ff0bdf0 → f8df80820dc7321dc9b18c9644c3b8315999670b 
comment:4 Changed 5 months ago by
Commit:  f8df80820dc7321dc9b18c9644c3b8315999670b → 212ce1fa1ddb07ef9cf38168617491a5440bf3ee 

Branch pushed to git repo; I updated commit sha1. New commits:
212ce1f  polynomial_element.pyx: First version of `global_height`

comment:5 Changed 5 months ago by
Commit:  212ce1fa1ddb07ef9cf38168617491a5440bf3ee → c64289026ad88254fb7bb97196b4e4484b1dedc8 

Branch pushed to git repo; I updated commit sha1. New commits:
c642890  multi_polynomial_libsingular.pyx: `global_height`

comment:6 Changed 5 months ago by
Commit:  c64289026ad88254fb7bb97196b4e4484b1dedc8 → 0c6a1763a5a7a2a710c28d37af19a91c7a2ac893 

Branch pushed to git repo; I updated commit sha1. New commits:
0c6a176  More examples

comment:7 Changed 5 months ago by
Status:  new → needs_review 

comment:8 Changed 5 months ago by
Commit:  0c6a1763a5a7a2a710c28d37af19a91c7a2ac893 → c2242cb2eeb1b3df8f06176201be75bb0d848c12 

Branch pushed to git repo; I updated commit sha1. New commits:
c2242cb  Move `import` stmts to top and correct doc

comment:9 Changed 5 months ago by
Commit:  c2242cb2eeb1b3df8f06176201be75bb0d848c12 → 4ac23b81b323c1890fd57957cf15713c871044ef 

Branch pushed to git repo; I updated commit sha1. New commits:
4ac23b8  remove `QQbar`

comment:10 Changed 5 months ago by
Commit:  4ac23b81b323c1890fd57957cf15713c871044ef → a94e199b7070ea8c1c43a6ab5532133c7bb03075 

Branch pushed to git repo; I updated commit sha1. New commits:
a94e199  local_height and local_height_arch for polys

comment:11 Changed 5 months ago by
Commit:  a94e199b7070ea8c1c43a6ab5532133c7bb03075 → 4f4fe177c0e29784d67a5bae9a51af5a03167f13 

Branch pushed to git repo; I updated commit sha1. New commits:
4f4fe17  Correct doc

comment:12 Changed 5 months ago by
Reviewers:  → Ben Hutz 

Status:  needs_review → needs_work 
 doc test failures
sage t randomseed=304862427901863394857029643453589442307 src/sage/rings/polynomial/polynomial_element.pyx # 1 doctest failed sage t randomseed=304862427901863394857029643453589442307 src/sage/rings/polynomial/multi_polynomial_libsingular.pyx # 2 doctests failed
 line 5499 need blank line after INPUT in libsinglar.pyx
 add an example demonstrating that the result is independent of scaling
 I thought you were going to add the function so that this works for QQbar?
comment:13 Changed 5 months ago by
Commit:  4f4fe177c0e29784d67a5bae9a51af5a03167f13 → f2e818e1247dc7b70429dc50565af88df640aff8 

Branch pushed to git repo; I updated commit sha1. New commits:
f2e818e  Correct doc, remove `else` stmt

comment:14 Changed 5 months ago by
Commit:  f2e818e1247dc7b70429dc50565af88df640aff8 → 058b4d6d83272296adc97f96a34dd54e61147bc3 

Branch pushed to git repo; I updated commit sha1. New commits:
058b4d6  Init version of hegiht for QQbar

comment:15 Changed 5 months ago by
Branch:  u/ghguojing0/34060_poly_height → u/bhutz/34060_poly_heights 

Commit:  058b4d6d83272296adc97f96a34dd54e61147bc3 → d5aad0029645743225e79bbc59a16b6ddc6b2186 
comment:16 Changed 5 months ago by
I squashed your commits down to one and added the ticket number. I also added some documentation and fixed the QQbar code.
comment:17 Changed 5 months ago by
Branch:  u/bhutz/34060_poly_heights → u/ghguojing0/34060_ph 

Commit:  d5aad0029645743225e79bbc59a16b6ddc6b2186 → ad991a3875175e78e274c3fd01aa00d3a19d194c 
Status:  needs_work → needs_review 
comment:18 Changed 5 months ago by
Authors:  Jing Guo → Jing Guo, Ben Hutz 

Priority:  minor → major 
Reviewers:  Ben Hutz → Alexander Galarraga 
Status:  needs_review → positive_review 
Looks good to me.
comment:19 Changed 5 months ago by
Branch:  u/ghguojing0/34060_ph → ad991a3875175e78e274c3fd01aa00d3a19d194c 

Resolution:  → fixed 
Status:  positive_review → closed 
Branch pushed to git repo; I updated commit sha1. New commits:
Debug height function for polynomials according to email