Opened 6 months ago

Closed 5 months ago

#34060 closed enhancement (fixed)

Height function for polynomials on number fields

Reported by: Jing Guo Owned by:
Priority: major Milestone: sage-9.7
Component: algebra Keywords: gsoc2022
Cc: Ben Hutz, Alexander Galarraga Merged in:
Authors: Jing Guo, Ben Hutz Reviewers: Alexander Galarraga
Report Upstream: N/A Work issues:
Branch: ad991a3 (Commits, GitHub, GitLab) Commit: ad991a3875175e78e274c3fd01aa00d3a19d194c
Dependencies: Stopgaps:

Status badges

Description (last modified by Jing Guo)

As suggested in #33971, a new ticket for height function for polynomials on number fields is created.

We want to define the global absolute height function for polynomials.

Change History (19)

comment:1 Changed 6 months ago by Jing Guo

Description: modified (diff)

comment:2 Changed 6 months ago by git

Commit: 0d582710e18af55d4c7b3626a12237e322a806470b4dd00508d2df4c99c519fd9f968e190ff0bdf0

Branch pushed to git repo; I updated commit sha1. New commits:

0b4dd00Debug height function for polynomials according to email

comment:3 Changed 5 months ago by Jing Guo

Branch: u/gh-guojing0/33971_dyn_sys_heightu/gh-guojing0/34060_poly_height
Commit: 0b4dd00508d2df4c99c519fd9f968e190ff0bdf0f8df80820dc7321dc9b18c9644c3b8315999670b

comment:4 Changed 5 months ago by git

Commit: f8df80820dc7321dc9b18c9644c3b8315999670b212ce1fa1ddb07ef9cf38168617491a5440bf3ee

Branch pushed to git repo; I updated commit sha1. New commits:

212ce1fpolynomial_element.pyx: First version of `global_height`

comment:5 Changed 5 months ago by git

Commit: 212ce1fa1ddb07ef9cf38168617491a5440bf3eec64289026ad88254fb7bb97196b4e4484b1dedc8

Branch pushed to git repo; I updated commit sha1. New commits:

c642890multi_polynomial_libsingular.pyx: `global_height`

comment:6 Changed 5 months ago by git

Commit: c64289026ad88254fb7bb97196b4e4484b1dedc80c6a1763a5a7a2a710c28d37af19a91c7a2ac893

Branch pushed to git repo; I updated commit sha1. New commits:

0c6a176More examples

comment:7 Changed 5 months ago by Jing Guo

Status: newneeds_review

comment:8 Changed 5 months ago by git

Commit: 0c6a1763a5a7a2a710c28d37af19a91c7a2ac893c2242cb2eeb1b3df8f06176201be75bb0d848c12

Branch pushed to git repo; I updated commit sha1. New commits:

c2242cbMove `import` stmts to top and correct doc

comment:9 Changed 5 months ago by git

Commit: c2242cb2eeb1b3df8f06176201be75bb0d848c124ac23b81b323c1890fd57957cf15713c871044ef

Branch pushed to git repo; I updated commit sha1. New commits:

4ac23b8remove `QQbar`

comment:10 Changed 5 months ago by git

Commit: 4ac23b81b323c1890fd57957cf15713c871044efa94e199b7070ea8c1c43a6ab5532133c7bb03075

Branch pushed to git repo; I updated commit sha1. New commits:

a94e199local_height and local_height_arch for polys

comment:11 Changed 5 months ago by git

Commit: a94e199b7070ea8c1c43a6ab5532133c7bb030754f4fe177c0e29784d67a5bae9a51af5a03167f13

Branch pushed to git repo; I updated commit sha1. New commits:

4f4fe17Correct doc

comment:12 Changed 5 months ago by Ben Hutz

Reviewers: Ben Hutz
Status: needs_reviewneeds_work
  • doc test failures
    sage -t --random-seed=304862427901863394857029643453589442307 src/sage/rings/polynomial/polynomial_element.pyx  # 1 doctest failed
    sage -t --random-seed=304862427901863394857029643453589442307 src/sage/rings/polynomial/multi_polynomial_libsingular.pyx  # 2 doctests failed
    
  • line 5499 need blank line after INPUT in libsinglar.pyx
  • add an example demonstrating that the result is independent of scaling
  • I thought you were going to add the function so that this works for QQbar?

comment:13 Changed 5 months ago by git

Commit: 4f4fe177c0e29784d67a5bae9a51af5a03167f13f2e818e1247dc7b70429dc50565af88df640aff8

Branch pushed to git repo; I updated commit sha1. New commits:

f2e818eCorrect doc, remove `else` stmt

comment:14 Changed 5 months ago by git

Commit: f2e818e1247dc7b70429dc50565af88df640aff8058b4d6d83272296adc97f96a34dd54e61147bc3

Branch pushed to git repo; I updated commit sha1. New commits:

058b4d6Init version of hegiht for QQbar

comment:15 Changed 5 months ago by Ben Hutz

Branch: u/gh-guojing0/34060_poly_heightu/bhutz/34060_poly_heights
Commit: 058b4d6d83272296adc97f96a34dd54e61147bc3d5aad0029645743225e79bbc59a16b6ddc6b2186

New commits:

c1b22a134060: initial implementation of heights for polynomials
d5aad0034060: code cleanup and QQbar fixes

comment:16 Changed 5 months ago by Ben Hutz

I squashed your commits down to one and added the ticket number. I also added some documentation and fixed the QQbar code.

comment:17 Changed 5 months ago by Jing Guo

Branch: u/bhutz/34060_poly_heightsu/gh-guojing0/34060_ph
Commit: d5aad0029645743225e79bbc59a16b6ddc6b2186ad991a3875175e78e274c3fd01aa00d3a19d194c
Status: needs_workneeds_review

Thanks to Alex, with his help, we have provided Number Field and prec examples for various height functions in all three files.


New commits:

c1b22a134060: initial implementation of heights for polynomials
d5aad0034060: code cleanup and QQbar fixes
ad991a334060: Number field and `prec` examples

comment:18 Changed 5 months ago by Alexander Galarraga

Authors: Jing GuoJing Guo, Ben Hutz
Priority: minormajor
Reviewers: Ben HutzAlexander Galarraga
Status: needs_reviewpositive_review

Looks good to me.

comment:19 Changed 5 months ago by Volker Braun

Branch: u/gh-guojing0/34060_phad991a3875175e78e274c3fd01aa00d3a19d194c
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.