Opened 2 months ago

Closed 2 months ago

#33967 closed enhancement (fixed)

sage -t: Print git commit hash and SAGE_LOCAL, SAGE_VENV

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.7
Component: doctest framework Keywords:
Cc: jhpalmieri, fbissey Merged in:
Authors: Matthias Koeppe Reviewers: John Palmieri
Report Upstream: N/A Work issues:
Branch: f2468ab (Commits, GitHub, GitLab) Commit: f2468abaa1275cf58dd1ad5cafd111478d0df5ba
Dependencies: #32937 Stopgaps:

Status badges

Description

sage -t already prints the current branch. We add some more information so that the log files *test*.log become more useful.

Change History (9)

comment:1 Changed 2 months ago by mkoeppe

  • Dependencies set to #32937

comment:2 Changed 2 months ago by mkoeppe

  • Branch set to u/mkoeppe/sage__t__print_git_commit_hash_and_sage_local__sage_venv

comment:3 Changed 2 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to f2468abaa1275cf58dd1ad5cafd111478d0df5ba
  • Status changed from new to needs_review

New commits:

​4ae68ccfoo
​d242f96src/sage/doctest/control.py: Show also 'git describe --always --dirty'
​f2468absrc/sage/doctest/control.py: Show SAGE_LOCAL, SAGE_VENV

comment:5 Changed 2 months ago by jhpalmieri

  • Cc fbissey added

Looks okay to me. @fbissey: okay from the distro point of view?

comment:6 Changed 2 months ago by fbissey

It certainly looks OK to me. You can go ahead with a positive review.

comment:7 Changed 2 months ago by jhpalmieri

  • Reviewers set to John Palmieri
  • Status changed from needs_review to positive_review

comment:8 Changed 2 months ago by mkoeppe

Thanks!

comment:9 Changed 2 months ago by vbraun

  • Branch changed from u/mkoeppe/sage__t__print_git_commit_hash_and_sage_local__sage_venv to f2468abaa1275cf58dd1ad5cafd111478d0df5ba
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.