Opened 4 months ago

Closed 3 months ago

#33966 closed defect (fixed)

KnotInfo interface returns wrong braid_notation for the unknot

Reported by: Sebastian Oehms Owned by:
Priority: major Milestone: sage-9.7
Component: algebraic geometry Keywords:
Cc: Merged in:
Authors: Sebastian Oehms Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 99345e1 (Commits, GitHub, GitLab) Commit: 99345e14d8182d09ac8da35a53af78964d77c2e8
Dependencies: Stopgaps:

Status badges

Description

The original database does not provide a value for the braid_notation of the unknot. Thus this value has been set individually in the interface, but unfortunately this value corresponds to a disjoint union of two unknots. This bug remained unnoticed because the construction of a link from a braid in Sage erases all additional unknots.

Change History (5)

comment:1 Changed 4 months ago by Sebastian Oehms

Branch: u/soehms/fix_unknot_braid_notation_knotinfo_33966

comment:2 Changed 4 months ago by Sebastian Oehms

Authors: Sebastian Oehms
Commit: 99345e14d8182d09ac8da35a53af78964d77c2e8
Status: newneeds_review

New commits:

99345e133966: initial

comment:3 Changed 3 months ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:4 Changed 3 months ago by Sebastian Oehms

Thanks

comment:5 Changed 3 months ago by Volker Braun

Branch: u/soehms/fix_unknot_braid_notation_knotinfo_3396699345e14d8182d09ac8da35a53af78964d77c2e8
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.