Opened 2 months ago

Closed 2 months ago

#33956 closed enhancement (fixed)

some better .join with iterator inside

Reported by: chapoton Owned by:
Priority: minor Milestone: sage-9.7
Component: refactoring Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: aa7d2e4 (Commits, GitHub, GitLab) Commit: aa7d2e4cad01772483add28e3e6c884809b4e9ee
Dependencies: Stopgaps:

Status badges

Description


Change History (6)

comment:1 Changed 2 months ago by chapoton

  • Branch set to u/chapoton/33956
  • Commit set to aa7d2e4cad01772483add28e3e6c884809b4e9ee
  • Status changed from new to needs_review

New commits:

aa7d2e4some better .join with no list inside

comment:2 Changed 2 months ago by dcoudert

  • Reviewers set to David Coudert

These changes looks good to me. However, the reported pyflakes errors are potential bugs and certainly deserves dedicated tickets.

comment:3 Changed 2 months ago by chapoton

Salut,

le fichier "src/sage/graphs/graph_database.py" est en déshérence totale, abandonné par tout le monde depuis longtemps..

comment:4 Changed 2 months ago by dcoudert

Je me demande si des gens utilisent...

comment:5 Changed 2 months ago by dcoudert

  • Status changed from needs_review to positive_review

LGTM.

comment:6 Changed 2 months ago by vbraun

  • Branch changed from u/chapoton/33956 to aa7d2e4cad01772483add28e3e6c884809b4e9ee
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.