Opened 7 months ago

Closed 4 months ago

#33861 closed defect (invalid)

Incompatibility with ecm-7.0.5

Reported by: Gonzalo Tornaría Owned by:
Priority: critical Milestone: sage-duplicate/invalid/wontfix
Component: interfaces Keywords:
Cc: Merged in:
Authors: Reviewers: Kwankyu Lee
Report Upstream: N/A Work issues:
Branch: u/tornaria/33861 (Commits, GitHub, GitLab) Commit: 7df4dd17e0c99522723ea84573a49eb67bdd0509
Dependencies: Stopgaps:

Status badges

Description

ecm-7.0.5 was released a couple of weeks ago, output was slightly changed making ecm.time() broken. Unfortunately I didn't doctest sage after rc3 and before the final 9.6 so I didn't catch it in time.

Actual failures:

**********************************************************************
File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/interfaces/ecm.py", line 717, in sage.interfaces.ecm.ECM.time
Failed example:
    ecm.time(n, 35)                  # random output
Exception raised:
    Traceback (most recent call last):
      File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/doctest/forker.py", line 695, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/doctest/forker.py", line 1093, in compile_and_execute
        exec(compiled, globs)
      File "<doctest sage.interfaces.ecm.ECM.time[1]>", line 1, in <module>
        ecm.time(n, Integer(35))                  # random output
      File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/interfaces/ecm.py", line 770, in time
        while next(out_lines) != title_curves:
    StopIteration
**********************************************************************
File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/interfaces/ecm.py", line 720, in sage.interfaces.ecm.ECM.time
Failed example:
    ecm.time(n, 30, verbose=True)     # random output
Exception raised:
    Traceback (most recent call last):
      File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/doctest/forker.py", line 695, in _run
        self.compile_and_execute(example, compiler, test.globs)
      File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/doctest/forker.py", line 1093, in compile_and_execute
        exec(compiled, globs)                                                                                                                                 
      File "<doctest sage.interfaces.ecm.ECM.time[2]>", line 1, in <module>                                                                                   
        ecm.time(n, Integer(30), verbose=True)     # random output
      File "/builddir/sage-9.6/pkgs/sagemath-standard/build/lib.linux-x86_64-3.10/sage/interfaces/ecm.py", line 770, in time
        while next(out_lines) != title_curves:
    StopIteration
**********************************************************************

Change History (5)

comment:1 Changed 7 months ago by Gonzalo Tornaría

Authors: Gonzalo Tornaría
Branch: u/tornaria/33861
Commit: 7df4dd17e0c99522723ea84573a49eb67bdd0509
Status: newneeds_review

This seems to work, tested with ecm-7.0.4 and ecm-7.0.5.


New commits:

7df4dd1Trac #33861: fix ecm.time() so it works with ecm-7.0.5

comment:2 Changed 7 months ago by Gonzalo Tornaría

#31325 includes a patch with similar effect to this, so this one can be dropped if that ticket is merged. Sorry for the noise.

comment:3 Changed 7 months ago by Matthias Köppe

Authors: Gonzalo Tornaría
Milestone: sage-9.7sage-duplicate/invalid/wontfix

dup of #31325

comment:4 Changed 4 months ago by Kwankyu Lee

Reviewers: Kwankyu Lee
Status: needs_reviewpositive_review

Yes.

comment:5 Changed 4 months ago by Matthias Köppe

Resolution: invalid
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.