#33791 closed enhancement (fixed)
cicygwin: Refactor using reusable workflows
Reported by:  Matthias Köppe  Owned by:  

Priority:  minor  Milestone:  sage9.7 
Component:  porting: Cygwin  Keywords:  
Cc:  Dima Pasechnik, ghkliem, Tobias Diez  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Dima Pasechnik 
Report Upstream:  N/A  Work issues:  
Branch:  e221c50 (Commits, GitHub, GitLab)  Commit:  
Dependencies:  #33782  Stopgaps: 
Description (last modified by )
We refactor cicygwinstandard.yml
using the new reusable workflow cygwin.yml
(see https://docs.github.com/en/actions/usingworkflows/reusingworkflows for this new GH Actions feature).
We also remove cicygwinminimal.yml
; this configuration has not run successfully for a long time, and there is no expectation that it will be fixed.
The workflow includes optional steps that are useful for upstream CIs. First uses:
Change History (22)
comment:1 Changed 5 months ago by
Dependencies:  → #33782 

Milestone:  sage9.6 → sage9.7 
comment:2 Changed 5 months ago by
Branch:  → u/mkoeppe/ci_cygwin__refactor_using_reusable_workflows 

comment:3 Changed 5 months ago by
Commit:  → f8f5d5d111a119f121f5136a13e744cbd34ad7b6 

comment:4 Changed 5 months ago by
Commit:  f8f5d5d111a119f121f5136a13e744cbd34ad7b6 → b6986e0f86d5403e6cd4267e53c0c2b13ae2d1c6 

Branch pushed to git repo; I updated commit sha1. New commits:
b6986e0  .github/workflows/cygwin.yml: Fixup

comment:5 Changed 5 months ago by
Commit:  b6986e0f86d5403e6cd4267e53c0c2b13ae2d1c6 → 147797ecf0ec76858e82b17b9c7a2e60feed5065 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
147797e  .github/workflows/cygwin.yml: Fixup

comment:6 Changed 5 months ago by
Authors:  → Matthias Koeppe 

Reviewers:  → https://github.com/sagemath/sagetracmirror/actions/runs/2265012437 
comment:7 Changed 5 months ago by
Work issues:  → Generalize so it can be used upstream  https://github.com/kimwalisch/primecount/blob/master/.github/workflows/cisage.yml 

comment:8 Changed 5 months ago by
Commit:  147797ecf0ec76858e82b17b9c7a2e60feed5065 → d86ac0560258f4041ef11a0c6d86224470786515 

Branch pushed to git repo; I updated commit sha1. New commits:
d86ac05  .github/workflows/cygwin.yml: Add steps for upstream CIs

comment:9 Changed 5 months ago by
Commit:  d86ac0560258f4041ef11a0c6d86224470786515 → 390b3664670f19fb7397188e38c2d15d8c1bc96a 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
390b366  .github/workflows/cygwin.yml: Add steps for upstream CIs

comment:10 Changed 5 months ago by
Commit:  390b3664670f19fb7397188e38c2d15d8c1bc96a → eb60dc18d300c261252a24f1495b7587927b7f90 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
eb60dc1  .github/workflows/cygwin.yml: Add steps for upstream CIs

comment:11 Changed 5 months ago by
Commit:  eb60dc18d300c261252a24f1495b7587927b7f90 → d9a66a20f747617847b6e0b6f96a416eef1e5057 

comment:12 Changed 5 months ago by
Commit:  d9a66a20f747617847b6e0b6f96a416eef1e5057 → 4c5715fcf6911187ab660ec1ae5d2483fa3b6198 

Branch pushed to git repo; I updated commit sha1. New commits:
4c5715f  .github/workflows/cygwin.yml: Handle inputs.prefix

comment:13 Changed 5 months ago by
Commit:  4c5715fcf6911187ab660ec1ae5d2483fa3b6198 → aa88608cc70f4b9791566fb20586883e67bac293 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
aa88608  .github/workflows/cygwin.yml: Handle inputs.prefix

comment:14 Changed 5 months ago by
Commit:  aa88608cc70f4b9791566fb20586883e67bac293 → 58efcb923560ed8b4edc199ddfc01c898e3e2cfe 

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
58efcb9  .github/workflows/cygwin.yml: Handle inputs.prefix

comment:15 Changed 5 months ago by
Commit:  58efcb923560ed8b4edc199ddfc01c898e3e2cfe → a51790cd398137ebcfb6553dccdc9115c8f42f17 

Branch pushed to git repo; I updated commit sha1. New commits:
a51790c  .github/workflows/cygwin.yml: Fix quoting

comment:16 Changed 5 months ago by
Cc:  ghkliem Tobias Diez added 

Description:  modified (diff) 
Reviewers:  https://github.com/sagemath/sagetracmirror/actions/runs/2265012437 → https://github.com/sagemath/sagetracmirror/actions/runs/2268082239 
Status:  new → needs_review 
Work issues:  Generalize so it can be used upstream  https://github.com/kimwalisch/primecount/blob/master/.github/workflows/cisage.yml 
comment:17 Changed 3 months ago by
Description:  modified (diff) 

comment:18 Changed 3 months ago by
Reviewers:  https://github.com/sagemath/sagetracmirror/actions/runs/2268082239 → Dima Pasechnik 

Status:  needs_review → positive_review 
lgtm
comment:19 Changed 3 months ago by
Commit:  a51790cd398137ebcfb6553dccdc9115c8f42f17 → e221c502f3e625a3bf235158924a2b40fee9eccf 

Status:  positive_review → needs_review 
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:
0d7bfe8  .github/workflows: Refactor cicygwinstandard.yml through cygwin.yml, remove cicygwinminimal.yml

3cf7ea6  .github/workflows/cicygwinstandard.yml: Remove continueonerror

bacba6b  .github/workflows/cygwin.yml: Fixup

5c8e570  .github/workflows/cygwin.yml: Add steps for upstream CIs

8921487  .github/workflows/cygwin.yml: Pass on targets_pre, targets_optional

fb61ebc  .github/workflows/cygwin.yml: Use correct shell when preparing logs artifact

0ac57e1  .github/workflows/cygwin.yml: Handle inputs.prefix

5e52c96  .github/workflows/cygwin.yml: Fix quoting

e221c50  .github/workflows/cygwin.yml: Use inputs.sage_trac_ticket

comment:20 Changed 3 months ago by
Status:  needs_review → positive_review 

Thanks! I've added another small fix
comment:21 Changed 3 months ago by
Branch:  u/mkoeppe/ci_cygwin__refactor_using_reusable_workflows → e221c502f3e625a3bf235158924a2b40fee9eccf 

Resolution:  → fixed 
Status:  positive_review → closed 
comment:22 Changed 7 weeks ago by
Commit:  e221c502f3e625a3bf235158924a2b40fee9eccf 

Component:  porting → porting: Cygwin 
Branch pushed to git repo; I updated commit sha1. New commits:
.github/workflows/cicygwinstandard.yml: Remove continueonerror