Opened 7 months ago

Closed 7 months ago

#33780 closed defect (fixed)

Issue with set_name for interior products with zero result

Reported by: Eric Gourgoulhon Owned by:
Priority: blocker Milestone: sage-9.6
Component: manifolds Keywords: interior_product, set_name
Cc: Michael Jung, Travis Scrimshaw Merged in:
Authors: Eric Gourgoulhon Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 960e0ed (Commits, GitHub, GitLab) Commit: 960e0ed8b4db0bc1dca031120fcc7f3013f21be6
Dependencies: Stopgaps:

Status badges

Description

In Sage 9.6.rc3, the interior product of a *named* vector field with a *named* 1-form resulting in zero yields an error:

sage: M = Manifold(2, 'M')
sage: X.<x, y> = M.chart()
sage: v = X.frame()[0]    # vector field d/dx
sage: f = X.coframe()[1]  # 1-form dy
sage: v.interior_product(f)
...
ValueError: the name of an immutable element cannot be changed

This is because set_name is called on M.zero_scalar_field(), while it should not.

Change History (5)

comment:1 Changed 7 months ago by Eric Gourgoulhon

Authors: Eric Gourgoulhon
Branch: public/manifolds/name_interior_prod-33780
Cc: Michael Jung Travis Scrimshaw added
Commit: 960e0ed8b4db0bc1dca031120fcc7f3013f21be6
Status: newneeds_review

Here is a fix.


New commits:

960e0edFix set_name bug in interior_product (Trac #33780)

comment:2 Changed 7 months ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

LGTM.

comment:3 Changed 7 months ago by Eric Gourgoulhon

Thank you for the review!

comment:4 Changed 7 months ago by Matthias Köppe

Priority: majorblocker

comment:5 Changed 7 months ago by Volker Braun

Branch: public/manifolds/name_interior_prod-33780960e0ed8b4db0bc1dca031120fcc7f3013f21be6
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.