Opened 2 months ago

Closed 3 weeks ago

#33776 closed enhancement (fixed)

move method distance_graph to graph.py

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-9.7
Component: graph theory Keywords:
Cc: tscrim Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 1edf47a (Commits, GitHub, GitLab) Commit: 1edf47a2da179e8d20418c2f157af16663e462ee
Dependencies: Stopgaps:

Status badges

Description (last modified by dcoudert)

Method distance_graph, introduced in #7533, has been designed for undirected graphs (see ​https://trac.sagemath.org/ticket/7533#comment:3) and moved to generic_graph.py in #7634 without care for directed graphs.

In this ticket, we move distance_graph to graph.py and improve it.

We let open the design of an adequate method for directed graphs and the extension to weighted (di)graphs.

Change History (4)

comment:1 Changed 2 months ago by dcoudert

  • Branch set to public/graphs/33776
  • Cc tscrim added
  • Commit set to 1edf47a2da179e8d20418c2f157af16663e462ee
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​8e7548btrac #33776: move distance_graph to graph.py
​f715576trac #33776: speed up
​1edf47atrac #33776: some care

comment:2 Changed 4 weeks ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 4 weeks ago by dcoudert

Thank you

comment:4 Changed 3 weeks ago by vbraun

  • Branch changed from public/graphs/33776 to 1edf47a2da179e8d20418c2f157af16663e462ee
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.