Opened 11 years ago

Closed 5 years ago

#3375 closed defect (invalid)

[with patch, mixed review] Fix building ntl on Solaris with make and ld

Reported by: fbissey Owned by: mabshoff
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: build Keywords: editor_mabshoff
Cc: polybori-discuss@… Merged in:
Authors: Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

OK so here is what got me through ntl on David's box. The mfile patch is against the copy in the ntl patch folder not the source. It also patch ntl spkg-install to properly setup and tune ntl as well as cleaning the installation bits introduced to accommodate Tim & I. I guess Tim and I will have to fend for ourselves separately. Also we submitted a lot of patch in the ntl style. Since I used some GNU-ism for building shared objects most of them will have to be revised.

Francois

Attachments (1)

ntl-sun.patch (2.9 KB) - added by fbissey 11 years ago.
patch for ntl spkg-install and patch/mfile

Download all attachments as: .zip

Change History (12)

Changed 11 years ago by fbissey

patch for ntl spkg-install and patch/mfile

comment:1 Changed 11 years ago by craigcitro

  • Keywords editor_mabshoff added
  • Summary changed from Fix building ntl on Solaris with make and ld [with patch needs review] to [with patch needs review] Fix building ntl on Solaris with make and ld

comment:2 Changed 11 years ago by mabshoff

  • Summary changed from [with patch needs review] Fix building ntl on Solaris with make and ld to [with patch, mixed review] Fix building ntl on Solaris with make and ld

Hi Francois,

Unless I am overlooking something you are removing the "-fPIC" lines from the link phase. Are you sure that will work?

Cheers,

Michael

comment:3 Changed 11 years ago by fbissey

It works all right on linux (no text relocations) but I indeed cannot guaranty it on other platform. I just checked the gcc manual and they recommand passing the PIC flag used during compilation as well when using -shared so best to put it back:

`-shared'

Produce a shared object which can then be linked with other objects to form an executable. Not all systems support this option. For predictable results, you must also specify the same set of options that were used to generate code (-fpic', -fPIC', or model suboptions) when you specify this option.(1)

comment:4 Changed 10 years ago by drkirkby

  • Cc polybori-discuss@… added
  • Report Upstream set to N/A

comment:5 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:6 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:7 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:8 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:9 Changed 5 years ago by fbissey

  • Status changed from needs_work to needs_review

comment:10 Changed 5 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

Looking through old tickets this is sooo obsolete. Won't fix/invalid.

comment:11 Changed 5 years ago by vbraun

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Resolution set to invalid
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.