Opened 10 months ago
Closed 10 months ago
#33746 closed defect (fixed)
Upgrade virtualenv, fix missing dependencies
| Reported by: | mkoeppe | Owned by: | |
|---|---|---|---|
| Priority: | blocker | Milestone: | sage-9.6 |
| Component: | packages: standard | Keywords: | |
| Cc: | yzh, jhpalmieri, dimpase, vbraun | Merged in: | |
| Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 8306b60 (Commits, GitHub, GitLab) | Commit: | 8306b6071510a136cc9045b0c309dba95f17ed1d |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
virtualenv was updated in #32482, but apparently it was forgotten to add some of its dependencies.
This only matters on systems without tox.
We upgrade virtualenv to the latest version, which only needs one extra package, platformdirs, and one upgrade of a dependency, filelock.
We use https://github.com/platformdirs/platformdirs/blob/main/CHANGES.rst#platformdirs-251-2022-02-19; the latest version changes the build system to hatchling, which we don't have yet.
Change History (6)
comment:1 Changed 10 months ago by
| Cc: | yzh added |
|---|
comment:2 Changed 10 months ago by
| Description: | modified (diff) |
|---|
comment:3 Changed 10 months ago by
| Branch: | → u/mkoeppe/upgrade_virtualenv__fix_missing_dependencies |
|---|
comment:4 Changed 10 months ago by
| Authors: | → Matthias Koeppe |
|---|---|
| Cc: | jhpalmieri dimpase vbraun added |
| Commit: | → 8306b6071510a136cc9045b0c309dba95f17ed1d |
| Description: | modified (diff) |
| Status: | new → needs_review |
comment:5 Changed 10 months ago by
| Reviewers: | → Dima Pasechnik |
|---|---|
| Status: | needs_review → positive_review |
lgtm
comment:6 Changed 10 months ago by
| Branch: | u/mkoeppe/upgrade_virtualenv__fix_missing_dependencies → 8306b6071510a136cc9045b0c309dba95f17ed1d |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
build/pkgs/virtualenv: Update to 20.14.1build/pkgs/platformdirs: New, dependency of virtualenvbuild/pkgs/filelock: Update to 3.6.0, needed for virtualenvbuild/pkgs/virtualenv/dependencies: Add platformdirsbuild/pkgs/platformdirs: Downgrade to 2.5.1, which still uses setuptools as the build system