#33746 closed defect (fixed)

Upgrade virtualenv, fix missing dependencies

Reported by: mkoeppe Owned by:
Priority: blocker Milestone: sage-9.6
Component: packages: standard Keywords:
Cc: yzh, jhpalmieri, dimpase, vbraun Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 8306b60 (Commits, GitHub, GitLab) Commit: 8306b6071510a136cc9045b0c309dba95f17ed1d
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

virtualenv was updated in #32482, but apparently it was forgotten to add some of its dependencies.

This only matters on systems without tox.

We upgrade virtualenv to the latest version, which only needs one extra package, platformdirs, and one upgrade of a dependency, filelock.

We use https://github.com/platformdirs/platformdirs/blob/main/CHANGES.rst#platformdirs-251-2022-02-19; the latest version changes the build system to hatchling, which we don't have yet.

Change History (6)

comment:1 Changed 10 months ago by mkoeppe

Cc: yzh added

comment:2 Changed 10 months ago by mkoeppe

Description: modified (diff)

comment:3 Changed 10 months ago by mkoeppe

Branch: u/mkoeppe/upgrade_virtualenv__fix_missing_dependencies

comment:4 Changed 10 months ago by mkoeppe

Authors: Matthias Koeppe
Cc: jhpalmieri dimpase vbraun added
Commit: 8306b6071510a136cc9045b0c309dba95f17ed1d
Description: modified (diff)
Status: newneeds_review

New commits:

da79f27build/pkgs/virtualenv: Update to 20.14.1
dfbbd6abuild/pkgs/platformdirs: New, dependency of virtualenv
ae25dd1build/pkgs/filelock: Update to 3.6.0, needed for virtualenv
62cf772build/pkgs/virtualenv/dependencies: Add platformdirs
8306b60build/pkgs/platformdirs: Downgrade to 2.5.1, which still uses setuptools as the build system

comment:5 Changed 10 months ago by dimpase

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

lgtm

comment:6 Changed 10 months ago by vbraun

Branch: u/mkoeppe/upgrade_virtualenv__fix_missing_dependencies8306b6071510a136cc9045b0c309dba95f17ed1d
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.