Opened 3 months ago

Closed 3 months ago

#33653 closed enhancement (fixed)

Set up join with both Vrepresentation and Hrepresentation

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.6
Component: geometry Keywords:
Cc: tscrim, yzh Merged in:
Authors: Jonathan Kliem Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: dfde30b (Commits, GitHub, GitLab) Commit: dfde30b1c5b99c8279123789a0068a993a157bba
Dependencies: Stopgaps:

Status badges

Description

Part of #29199.

Before:

sage: P = polytopes.cross_polytope(6)
sage: %timeit P.join(P)
5.77 ms ± 44.7 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
sage: P = polytopes.hypercube(6)
sage: %timeit P.join(P)
8.7 ms ± 5.83 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
sage: P = polytopes.permutahedron(6)
sage: %timeit P.join(P)
183 ms ± 83.2 µs per loop (mean ± std. dev. of 7 runs, 10 loops each)

After:

sage: P = polytopes.cross_polytope(6)
sage: %timeit P.join(P)
5.7 ms ± 21.6 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
sage: P = polytopes.hypercube(6)
sage: %timeit P.join(P)
4.74 ms ± 4.27 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)
sage: P = polytopes.permutahedron(6)
sage: %timeit P.join(P)
686 ms ± 4.63 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)
sage: P = polytopes.permutahedron(6, backend='field')
sage: %timeit P.join(P)
18.5 ms ± 137 µs per loop (mean ± std. dev. of 7 runs, 100 loops each)

Change History (4)

comment:1 Changed 3 months ago by git

  • Commit changed from 98470cc756050452dc0de4aa8cb75ad63f4ac988 to dfde30b1c5b99c8279123789a0068a993a157bba

Branch pushed to git repo; I updated commit sha1. New commits:

dfde30btypo

comment:2 Changed 3 months ago by gh-kliem

  • Cc tscrim yzh added
  • Status changed from new to needs_review

comment:3 Changed 3 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM. Patchbot failures are unrelated to this ticket.

comment:4 Changed 3 months ago by vbraun

  • Branch changed from u/gh-kliem/double_description_join to dfde30b1c5b99c8279123789a0068a993a157bba
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.