Opened 3 months ago

Last modified 5 days ago

#33613 needs_review enhancement

Pip package git_trac_command, add pip packages to conda environments

Reported by: mkoeppe Owned by:
Priority: minor Milestone: sage-9.7
Component: porting Keywords:
Cc: gh-tobiasdiez, dimpase Merged in:
Authors: Matthias Koeppe Reviewers:
Report Upstream: N/A Work issues:
Branch: u/mkoeppe/gitpod__install_git_trac_command (Commits, GitHub, GitLab) Commit: 2019f4791f0bc6edf6c9f35a1ae618206d02623b
Dependencies: #33852 Stopgaps:

Status badges

Description (last modified by mkoeppe)

This is a pip-installable package

python3 -m pip install git+https://github.com/sagemath/git-trac-command

... but it is best to be installed by the user in their system environment, not in SAGE_VENV.

For example, we want to make it available on Gitpod, in devcontainers, and the user-facing Sage Docker images.

In src/environment-dev.yml (#33740), it should be added as a pip: line. We implement a general mechanism for doing that. It also adds a number of pip-installable optional packages without conda package to src/environment-optional.yml.

Change History (26)

comment:1 Changed 3 months ago by mkoeppe

  • Summary changed from gitpod: Install sage-trac-command to gitpod: Install git-trac-command

comment:2 Changed 3 months ago by mkoeppe

  • Description modified (diff)

comment:3 Changed 3 months ago by mkoeppe

(Without #33589) I also get

(sage-sh) gitpod@sagemath-sagetracmirror-72wwexpcfmb:sagetrac-mirror$ git trac checkout 33608
Loading ticket #33608...
Checking out Trac #33608 remote branch u/klee/33608 -> local branch t/33608/33608...
Traceback (most recent call last):
    STDERR: Warning: Permanently added the ECDSA host key for IP address '104.197.143.230' to the list of known hosts.
    STDERR: Load key "/home/gitpod/.ssh/id_rsa": invalid format
    STDERR: git@trac.sagemath.org: Permission denied (publickey).
    STDERR: fatal: Could not read from remote repository.
    STDERR: 
    STDERR: Please make sure you have the correct access rights
    STDERR: and the repository exists.

comment:4 Changed 3 months ago by gh-tobiasdiez

Did you followed the steps outlined in sage's gitpod docs to add the ssh key?

comment:5 Changed 3 months ago by mkoeppe

  • Dependencies set to #33589

No. In #33589 we should make sure that fetching can be done without these steps.

comment:6 Changed 3 months ago by mkoeppe

  • Branch set to u/mkoeppe/gitpod__install_git_trac_command

comment:7 Changed 3 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Commit set to eacd393e820e277a5951c232d7ff1b28e63b7c87

Last 10 new commits:

a5d10a2Fix typo
4950bcfAdd fallback to github mirror
c235eadDisable pushing to github
40d1e23Always disable pushing to origin
89591c4Remove wrong trac from prebuild
3d450f3Update docs
e9035aeSilence semi-expected errors during (pre)build
8432e1dMerge #33589
8aaaf07build/pkgs/python3/distros/debian.txt: New
eacd393docker/.gitpod.Dockerfile: Install pip for system python, install git-trac-command

comment:8 Changed 3 months ago by git

  • Commit changed from eacd393e820e277a5951c232d7ff1b28e63b7c87 to 3f718616439635d213a2d50ac7263f0e6e549c3f

Branch pushed to git repo; I updated commit sha1. New commits:

3f71861docker/.gitpod.Dockerfile: hardcode python3-pip

comment:9 Changed 3 months ago by git

  • Commit changed from 3f718616439635d213a2d50ac7263f0e6e549c3f to 866a833c649f1388b2f552cddbe258eea96b8ecf

Branch pushed to git repo; I updated commit sha1. New commits:

866a833docker/.gitpod.Dockerfile: Run apt-get update first

comment:10 Changed 3 months ago by mkoeppe

  • Milestone changed from sage-9.6 to sage-9.7

comment:11 Changed 7 weeks ago by mkoeppe

  • Description modified (diff)
  • Summary changed from gitpod: Install git-trac-command to Script package git_trac_command

comment:12 Changed 7 weeks ago by mkoeppe

  • Description modified (diff)

comment:13 Changed 7 weeks ago by mkoeppe

  • Dependencies changed from #33589 to #33740, #33851

comment:14 Changed 7 weeks ago by mkoeppe

  • Dependencies changed from #33740, #33851 to #33740, #33822, #33851

comment:15 Changed 7 weeks ago by mkoeppe

  • Summary changed from Script package git_trac_command to Pip package git_trac_command

comment:16 Changed 7 weeks ago by git

  • Commit changed from 866a833c649f1388b2f552cddbe258eea96b8ecf to d2b8c4e2a4098d2bdecabb531e30feaa9b130306

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

ccbc21abootstrap, bootstrap-conda, src/doc/bootstrap: Use build/bin/sage-package directly
4560895src/doc/Makefile: Remove explicit use of SAGE_ROOT and the top-level sage script
7759f3cGenerate en/reference/repl/options.txt at build time, not bootstrap time
58ab878bootstrap-conda: Fix typo, generate->generating to match messages from bootstrap
12ea8cebuild/pkgs/_develop/distros: Add packages providing gpgconf
238b7bbbuild/pkgs/_develop/distros: Add packages providing ssh
01a126cMerge #33851
a74ccaabuild/pkgs/git_trac_command: New
e28f6d9build/pkgs/_develop/dependencies: Add git_trac_command
d2b8c4ebootstrap-conda: Also generate pip: lines

comment:17 Changed 7 weeks ago by git

  • Commit changed from d2b8c4e2a4098d2bdecabb531e30feaa9b130306 to ffde3710e644845ed19793054379f4a6dd6d5f68

Branch pushed to git repo; I updated commit sha1. New commits:

ffde371bootstrap-conda: Do not include packages that declare SAGERUNTIME as a dependency

comment:18 Changed 7 weeks ago by mkoeppe

  • Description modified (diff)
  • Status changed from new to needs_review

comment:19 Changed 5 weeks ago by git

  • Commit changed from ffde3710e644845ed19793054379f4a6dd6d5f68 to d6a916c084e0a34af856f83a2d5964193f9fb421

Branch pushed to git repo; I updated commit sha1. New commits:

d6a916cMerge tag '9.7.beta1' into t/33613/gitpod__install_git_trac_command

comment:20 Changed 5 weeks ago by mkoeppe

  • Cc dimpase added

comment:21 Changed 5 weeks ago by mkoeppe

  • Summary changed from Pip package git_trac_command to Pip package git_trac_command, add pip packages to conda environments

comment:22 Changed 5 weeks ago by mkoeppe

  • Dependencies changed from #33740, #33822, #33851 to #33852

comment:23 Changed 5 weeks ago by git

  • Commit changed from d6a916c084e0a34af856f83a2d5964193f9fb421 to 8e511f232585f98f18befe40945be71964b21d41

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

67c8238src/bin/sage: Print error to error output
bc77bfdbootstrap-conda: Write an additional comment
4c2adf7bootstrap-conda: Rewrite using fewer redirects
ac2c48dbuild/pkgs/git_trac_command: New
4a0b6f4bootstrap-conda: Also generate pip: lines
ef01ba4bootstrap-conda: Do not include packages that declare SAGERUNTIME as a dependency
8e511f2bootstrap-conda: Hardcode git_trac_command as a devel package

comment:24 Changed 5 weeks ago by mkoeppe

Rebased away from #33822, #33851.

Ready for review

comment:25 Changed 5 days ago by git

  • Commit changed from 8e511f232585f98f18befe40945be71964b21d41 to 94d6ec769cabfc91c18649447a67584a22ab111d

Branch pushed to git repo; I updated commit sha1. New commits:

94d6ec7Merge tag '9.7.beta3' into t/33613/gitpod__install_git_trac_command

comment:26 Changed 5 days ago by git

  • Commit changed from 94d6ec769cabfc91c18649447a67584a22ab111d to 2019f4791f0bc6edf6c9f35a1ae618206d02623b

Branch pushed to git repo; I updated commit sha1. New commits:

2019f47bootstrap-conda: Also check dependencies_order_only
Note: See TracTickets for help on using tickets.