Opened 4 months ago
Closed 4 months ago
#33487 closed enhancement (fixed)
Package CyLP
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.6 |
Component: | packages: optional | Keywords: | |
Cc: | gh-sheerluck, gh-tkralphs, slabbe, dcoudert, dimpase | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 8b27e69 (Commits, GitHub, GitLab) | Commit: | 8b27e69bcec975cfffc8220c440867b124d01fa6 |
Dependencies: | Stopgaps: |
Description
https://github.com/coin-or/CyLP
Needed for running cvxpy (#31962) with a CBC backend.
Change History (14)
comment:1 Changed 4 months ago by
- Branch set to u/mkoeppe/package_cylp
comment:2 Changed 4 months ago by
- Cc gh-tkralphs added
- Commit set to 3edafec0645223eeedf9fa544aadfd1b82b50786
comment:3 Changed 4 months ago by
Without CYLP_USE_CYTHON
, running into https://github.com/coin-or/CyLP/issues/148 with Python 3.10.
comment:4 Changed 4 months ago by
- Commit changed from 3edafec0645223eeedf9fa544aadfd1b82b50786 to 8b27e69bcec975cfffc8220c440867b124d01fa6
Branch pushed to git repo; I updated commit sha1. New commits:
8b27e69 | build/pkgs/cylp: Add megapatch 'Re-generating with Cython 0.29.27 for Python 3.10 compatibility', do not use CYLP_USE_CYTHON
|
comment:5 Changed 4 months ago by
- Status changed from new to needs_review
This works for me on macOS with Python 3.10 and CBC 2.10.7 installed from homebrew. https://github.com/coin-or/CyLP#modeling-example works as expected.
comment:6 Changed 4 months ago by
- Cc slabbe dcoudert dimpase added
comment:7 Changed 4 months ago by
- Milestone changed from sage-9.7 to sage-9.6
comment:8 Changed 4 months ago by
Also builds OK with tox -e docker-ubuntu-trusty-maximal -- cylp
(this uses our cbc
spkg, currently still at 2.9.4)
comment:9 Changed 4 months ago by
Also builds OK with tox -e docker-ubuntu-bionic-maximal -- cylp
(using system coinor-cbc (2.9.9+repack1-1))
comment:10 Changed 4 months ago by
I'll not run the full portability suite now. I think this is good enough for a new optional package.
comment:11 Changed 4 months ago by
- Status changed from needs_review to positive_review
That is a pretty massive patch. Although I guess the time for them for the next release is probably a bit away, so I guess it is necessary.
This builds and works fine for me.
comment:12 Changed 4 months ago by
- Reviewers set to Travis Scrimshaw
comment:13 Changed 4 months ago by
Thanks!
comment:14 Changed 4 months ago by
- Branch changed from u/mkoeppe/package_cylp to 8b27e69bcec975cfffc8220c440867b124d01fa6
- Resolution set to fixed
- Status changed from positive_review to closed
Is building with
CYLP_USE_CYTHON=1
still supported / ever tested? Fails for me without diagnosticsNew commits:
build/pkgs/cylp: New