Opened 4 months ago

Closed 4 months ago

#33402 closed enhancement (fixed)

sage.geometry.polyhedron: More # optional

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.6
Component: refactoring Keywords:
Cc: gh-kliem Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: 065c627 (Commits, GitHub, GitLab) Commit: 065c627922622e922fe89e2051d7b49e92b3c0f1
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

(cherry-picked from #32432)

Change History (9)

comment:1 Changed 4 months ago by mkoeppe

  • Branch set to u/mkoeppe/sage_geometry_polyhedron__more___optional

comment:2 Changed 4 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc gh-kliem added
  • Commit set to 82f2e18ce57201332294502dc5f9e61dc612ad3b
  • Status changed from new to needs_review

New commits:

460072dsrc/sage/geometry/polyhedron/base3.py: Mark a doctest # optional - sage.groups
57735d9src/sage/geometry/polyhedron/base3.py: Add some # optional - sage.rings.number_field, sage.combinat
f305cccsrc/sage/geometry/polyhedron/base3.py: Mark doctests # optional - sage.combinat
498a534src/sage/geometry/polyhedron/base3.py: Mark a doctest # optional - sage.number_field
a32bf42src/sage/geometry/polyhedron/library.py: Add # optional - sage.rings.number_field
07d7358src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx: Add # optional - sage.combinat
8267aabsrc/sage/geometry/polyhedron/ppl_lattice_polytope.py b/src/sage/geometry/polyhedron/ppl_lattice_polytope.py: Mark doctests # optional - sage.groups sage.graphs
82f2e18src/sage/geometry/polyhedron/backend_normaliz.py: Add missing # optional - sage.rings.number_field

comment:3 Changed 4 months ago by git

  • Commit changed from 82f2e18ce57201332294502dc5f9e61dc612ad3b to fa15fd3c419dee353309931db3f0e408ff64beee

Branch pushed to git repo; I updated commit sha1. New commits:

fa15fd3src/sage/geometry/polyhedron/base0.py: Add # optional - sage.rings.number_field

comment:4 Changed 4 months ago by git

  • Commit changed from fa15fd3c419dee353309931db3f0e408ff64beee to 302bc3c47e3b5e377dcd4b4438b386924109d2ba

Branch pushed to git repo; I updated commit sha1. New commits:

302bc3csrc/sage/geometry/polyhedron/face.py: Mark doctests # optional - sage.combinat

comment:5 Changed 4 months ago by git

  • Commit changed from 302bc3c47e3b5e377dcd4b4438b386924109d2ba to 065c627922622e922fe89e2051d7b49e92b3c0f1

Branch pushed to git repo; I updated commit sha1. New commits:

065c627src/sage/geometry/polyhedron/base1.py: Change an example from RR to RDF, add # optional - sage.rings.number_field, sage.symbolic

comment:6 Changed 4 months ago by mkoeppe

  • Description modified (diff)

comment:7 Changed 4 months ago by gh-kliem

  • Reviewers set to Jonathan Kliem
  • Status changed from needs_review to positive_review

LGTM.

comment:8 Changed 4 months ago by mkoeppe

Thank you!

comment:9 Changed 4 months ago by vbraun

  • Branch changed from u/mkoeppe/sage_geometry_polyhedron__more___optional to 065c627922622e922fe89e2051d7b49e92b3c0f1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.