Opened 4 months ago

Closed 3 months ago

#33157 closed defect (fixed)

Use `parent` function, not method, to convert SR to RBF or CBF

Reported by: mmezzarobba Owned by:
Priority: major Milestone: sage-9.6
Component: symbolics Keywords:
Cc: slelievre Merged in:
Authors: Marc Mezzarobba Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: a995d14 (Commits, GitHub, GitLab) Commit: a995d143fd651bb41961cc5dcbb60631b0adc1ea
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-mwageringel)

Use parent(a) rather than a.parent() to accommodate floats, ints, etc.

This fixes yet another issue with conversions from symbolic expression to balls, reported by Markus Wageringel at #32871.

In Sage 9.5.beta7:

sage: a = acos(float(1/4) * sqrt(int(5)))
sage: CBF(a)
AttributeError                            Traceback (most recent call last)
AttributeError: 'float' object has no attribute 'parent'

With the fix in this ticket:

sage: CBF(acos(float(1/4) * sqrt(int(5))))

Change History (7)

comment:1 Changed 4 months ago by mmezzarobba

  • Branch set to u/mmezzarobba/33157-SRtoCBF
  • Commit set to a995d143fd651bb41961cc5dcbb60631b0adc1ea
  • Status changed from new to needs_review

New commits:

a995d14#33157 fix issue in SR → CBF conversion from #32871

comment:2 Changed 4 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm, thanks!

comment:3 Changed 4 months ago by gh-mwageringel

Thank you.

comment:4 Changed 4 months ago by slelievre

  • Cc slelievre added
  • Description modified (diff)
  • Summary changed from Issue with SR → [RC]BF conversion to Use `parent` function, not method, to convert SR to RBF or CBF

comment:5 Changed 4 months ago by gh-mwageringel

  • Description modified (diff)

comment:6 Changed 4 months ago by slelievre

  • Milestone changed from sage-9.5 to sage-9.6

Setting milestone to 9.6 now that 9.5 is out.

comment:7 Changed 3 months ago by vbraun

  • Branch changed from u/mmezzarobba/33157-SRtoCBF to a995d143fd651bb41961cc5dcbb60631b0adc1ea
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.