Opened 4 months ago
Closed 4 months ago
#33151 closed defect (fixed)
sage-conf_pypi does not build wheelhouse
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | blocker | Milestone: | sage-9.5 |
Component: | distribution | Keywords: | |
Cc: | dimpase | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | 04066ab (Commits, GitHub, GitLab) | Commit: | 04066abb68c6bb101bc7543c85c2656822f0f112 |
Dependencies: | Stopgaps: |
Description (last modified by )
Contrary to what is claimed in the README in https://pypi.org/project/sage-conf/9.5rc0/, after pip install sage_conf==9.5rc0
, there is no wheelhouse available: ls $(sage-config SAGE_SPKG_WHEELS)
gives "No such file or directory".
We fix this by changing make build-local
to make build
in the install script (and fixing a bug that caused make build
to fail).
Distribution using the branch of this ticket uploaded as https://pypi.org/project/sage-conf/9.5rc0.post1/
Change History (10)
comment:1 Changed 4 months ago by
- Branch set to u/mkoeppe/sage_conf_pypi_does_not_build_wheelhouse
comment:2 Changed 4 months ago by
- Commit set to 250e5e0c6d3411c9e8118abf05048eeba44838bc
comment:3 Changed 4 months ago by
- Cc dimpase added
- Description modified (diff)
- Status changed from new to needs_review
comment:4 Changed 4 months ago by
- Commit changed from 250e5e0c6d3411c9e8118abf05048eeba44838bc to 04066abb68c6bb101bc7543c85c2656822f0f112
Branch pushed to git repo; I updated commit sha1. New commits:
04066ab | pkgs/sage-conf/README.rst: Add links to source code
|
comment:5 Changed 4 months ago by
What is the aim of this ticket, it's a bit unclear from the description.
comment:6 Changed 4 months ago by
- Description modified (diff)
comment:7 Changed 4 months ago by
- Reviewers set to Dima Pasechnik
- Status changed from needs_review to positive_review
lgtm
comment:8 Changed 4 months ago by
Thanks.
comment:9 Changed 4 months ago by
- Priority changed from major to blocker
comment:10 Changed 4 months ago by
- Branch changed from u/mkoeppe/sage_conf_pypi_does_not_build_wheelhouse to 04066abb68c6bb101bc7543c85c2656822f0f112
- Resolution set to fixed
- Status changed from positive_review to closed
Branch pushed to git repo; I updated commit sha1. New commits:
pkgs/sage-conf_pypi/setup.py: Use --disable-doc