Opened 13 months ago
Closed 12 months ago
#33140 closed defect (fixed)
GH Actions (macOS): Fix filtering of experimental packages
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | sage-9.6 |
Component: | porting | Keywords: | |
Cc: | dimpase, gh-kliem | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | 41ec3aa (Commits, GitHub, GitLab) | Commit: | 41ec3aa15693c69d68e9fdf2fae08e1999706a55 |
Dependencies: | Stopgaps: |
Description (last modified by )
Filtering by $targets_pattern
is broken, so the jobs for experimental packages do too much work.
see for example https://github.com/sagemath/sage/runs/4752780943?check_suite_focus=true, which was supposed to only build packages starting with 0-g
, but TARGETS_OPTIONAL=scipoptsuite modular_decomposition awali gdb deformation cocoalib surf gambit libtheora lie gap3 valgrind qepcad
.
We also update some tox.ini
settings for macos.
Change History (10)
comment:1 Changed 13 months ago by
Branch: | → u/mkoeppe/gh_actions__macos___fix_filtering_of_experimental_packages |
---|
comment:2 Changed 13 months ago by
Authors: | → Matthias Koeppe |
---|---|
Cc: | dimpase gh-kliem added |
Commit: | → 12f88cfaafdd85b85f4ac117793cc4a2616476cc |
Status: | new → needs_review |
comment:3 Changed 13 months ago by
Commit: | 12f88cfaafdd85b85f4ac117793cc4a2616476cc → 41ec3aa15693c69d68e9fdf2fae08e1999706a55 |
---|
comment:4 Changed 13 months ago by
Description: | modified (diff) |
---|
comment:6 Changed 12 months ago by
Milestone: | sage-9.5 → sage-9.6 |
---|
Set milestone to sage-9.6 after Sage 9.5 release.
comment:7 Changed 12 months ago by
Can we please get this in? It will make the portability suite faster.
comment:8 Changed 12 months ago by
Reviewers: | → Dima Pasechnik |
---|---|
Status: | needs_review → positive_review |
lgtm
comment:10 Changed 12 months ago by
Branch: | u/mkoeppe/gh_actions__macos___fix_filtering_of_experimental_packages → 41ec3aa15693c69d68e9fdf2fae08e1999706a55 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
.github/workflows/tox.yml (local-macos): Fix filtering of experimental packages
.github/workflows/tox.yml (local-macos): Group optional/experimental package builds into fewer jobs