Opened 5 months ago
Closed 3 months ago
#33123 closed enhancement (fixed)
Move construction methods to Polyhedron_base5
Reported by:  ghkliem  Owned by:  

Priority:  major  Milestone:  sage9.6 
Component:  geometry  Keywords:  
Cc:  mkoeppe  Merged in:  
Authors:  Jonathan Kliem  Reviewers:  Matthias Koeppe 
Report Upstream:  N/A  Work issues:  
Branch:  8c25b61 (Commits, GitHub, GitLab)  Commit:  8c25b61308c2274e26407c3f0ee64c916d3dcddc 
Dependencies:  #32788  Stopgaps: 
Description
Part of #32651.
We move polytopal constructions to Polyhedron_base5
. We also group them according to their input.
Change History (13)
comment:1 Changed 5 months ago by
 Branch set to public/33123
 Cc mkoeppe added
 Commit set to 1bc44c94b82755f97dab6c6cfe24b31879c9f238
 Status changed from new to needs_review
comment:3 Changed 5 months ago by
 Commit changed from 1bc44c94b82755f97dab6c6cfe24b31879c9f238 to 3f329096ccb85f5082a346ecb98174777a30f05f
Branch pushed to git repo; I updated commit sha1. New commits:
3f32909  add base5.py

comment:4 Changed 5 months ago by
 Status changed from needs_work to needs_review
comment:5 Changed 4 months ago by
 Reviewers set to Matthias Koeppe
 Status changed from needs_review to positive_review
comment:6 Changed 4 months ago by
Thank you.
comment:7 Changed 3 months ago by
 Status changed from positive_review to needs_work
Merge failure on top of:
7fa1231b5b Trac #33121: PARI/GP for elliptic curve discrete logarithms (elllog) and Weil pairings (ellweilpairing)
63a49bea94 Trac #33119: Remove deprecated things in geometry/polyhedron
for sage9.6
7c5436cc8c Trac #32999: Remove imports from sage.libs.all
5abb9e8404 Trac #32976: LLL, min, max, short_vectors for IntegralLattice?
1e1263eb0f Trac #32801: Clean the use of weights in generic_graph.py  part 3
7d01de50a8 Trac #32800: Clean the use of weights in generic_graph.py  part 2
4bad770833 Trac #20343: Adding sage/plot/tikzpicture.py
51f7b326cf Trac #19951: Remove occurrences of trait_names
b41fb2fb18 Trac #33296: tox.ini: Add recommended package factor
db7554fa67 Trac #33277: build/pkgs/_recommended/dependencies
5d2a381c37 Trac #33196: tox.ini: Add centosstream8, centosstream9, remove defunct centos6
4fc783e6db Trac #33085: adjust dochtml label so doctests pass when html doc is not built/installed
45706f82b6 Trac #33033: Prepare sage.doctest for namespace packages
55fd5edb38 Trac #33027: zombie maxima process  if invoked from a script
b34c0d5ded Trac #31529: texlive: Add spkgconfigure.m4 and system package information; remove install script
c4e4a6387f Trac #31415: GH Actions workflow that builds documentation on each push
9cc853b81b Trac #33107: Generic cholesky() fails on the trivial matrix
88a98d50c3 Trac #33103: gitpod integration using Docker images from portability testing workflow
d4466d825b Trac #33102: some details in shuffle and multizeta
09de266470 Trac #33098: Add more void packages to distros/void.txt
73dd8d1cf5 Trac #33096: src/tox.ini (relint): Exclude editor temp files etc.
a0d0888f54 Trac #33095: again some details in Dyck words
4fa191a754 Trac #33071: Update pillow to 8.4
733ed250a3 Trac #33070: Package upgrades for Python 3.10 support
e4f3f1dc9b Trac #33069: Remove spkg speaklater
18ba1d8cdd Trac #33064: sage_docbuild: fails when cache cannot be saved
467c32cce3 Trac #33049: Update scipy to 1.7.3
2cf334f97d Trac #33048: Update setuptools to 59.8.0
3a4cc169b4 Trac #33045: ffmpeg tests time out
8fb89a37bb Trac #33039: Random doctest failure in continued_fraction_gosper
236856d0da Trac #33026: make BinaryQF.solve_integer() work for square discriminants
2ad7305f87 Trac #33015: Random failure in number_field_element.pyx
c45f12e9e6 Trac #33009: Move is_prism and is_bipyramid to combinatorial polyhedron
87011e965e Trac #33008: Polyhedron_base.facet_adjacency_matrix: Do not use face_lattice
46cc022732 Trac #33007: Remove imports from sage.interfaces.all
57fe9e661a Trac #33005: Add feature for pdftocairo
69d9945eb0 Trac #32993: add pictures to line.py documentation
3834fded18 Trac #32788: Permanently get rid of bare except: statements
0207af8674 Trac #32209: Allow evaluation of morphisms of schemes on points over different rings
206ff0b058 Trac #33269: fix for build/pkgs/tox/distros/gentoo.txt
6d154b634f Trac #33226: Support giac1.7.0.45 in doctests
d5d2e23df5 Trac #33187: Allow gcc/gfortran 12
59c0620436 Trac #33140: GH Actions (macOS): Fix filtering of experimental packages
0669c95412 Trac #32211: Upgrade FLINT to 2.8.4, arb to 2.22.1
508ea2d518 Trac #33284: Fix macro name clash introduced in #25633
b511685469 Trac #32989: Remove imports from sage.misc.all
9c6afb97c8 Trac #32505: Finitely presented graded modules over graded connected algebras
226937dfa9 Updated SageMath version to 9.6.beta0
merge was not clean: conflicts in src/sage/geometry/polyhedron/base.py
comment:8 Changed 3 months ago by
 Dependencies set to #32788
comment:9 Changed 3 months ago by
 Commit changed from 3f329096ccb85f5082a346ecb98174777a30f05f to 8c25b61308c2274e26407c3f0ee64c916d3dcddc
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
0113b72  code style again

6c08ce1  remove blank except in GIAC call

04a1f01  fix distinction between two calls

9905930  remove code duplication

d3df701  #32788 : ensure bare except: statements will not reappear

e92b905  mark polymake_expect import as optional

f463e49  comment before

9522357  Merge branch 'develop.9.5.beta6' into HEAD

de4faf6  Merge branch 'u/tmonteil/except_fix_branch' in 9.5.rc1

8c25b61  Merge #32788

comment:10 Changed 3 months ago by
 Status changed from needs_work to needs_review
comment:11 Changed 3 months ago by
Waiting for the patchbot
comment:12 Changed 3 months ago by
 Status changed from needs_review to positive_review
comment:13 Changed 3 months ago by
 Branch changed from public/33123 to 8c25b61308c2274e26407c3f0ee64c916d3dcddc
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
move polytopal construction to Polyhedron_base5