Opened 5 months ago

Closed 5 months ago

#33042 closed defect (fixed)

givaro spkg-configure: Reject too new versions

Reported by: mkoeppe Owned by:
Priority: blocker Milestone: sage-9.5
Component: build: configure Keywords:
Cc: dimpase, mjo, cpernet, fbissey, charpent, arojas Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 1da5d31 (Commits, GitHub, GitLab) Commit: 1da5d3130eeeff9b6797dac2b347c34cc26290d7
Dependencies: #32947 Stopgaps:

Status badges

Description (last modified by mkoeppe)

The linbox team has recently released new versions of their packages: givaro-4.2.0, fflas-ffpack-2.5.0, linbox-1.7.0, which some cutting-edge distributions are already shipping: https://repology.org/project/givaro/versions

Unfortunately our spkg-configure for givaro only checks a lower version bound, not an upper bound. We do not have an spkg-configure for linbox - that's #29631; so we try to build an old linbox with a new givaro, which fails (upstream does not support this). Hence these new, incompatible releases retroactively break released Sage versions.

This leads to build errors in our linbox spkg, such as

A workaround for users of released versions of Sage is to use ./configure --without-system-givaro.

Change History (16)

comment:1 Changed 5 months ago by mkoeppe

  • Authors set to Matthias Koeppe

comment:2 Changed 5 months ago by mkoeppe

  • Cc charpent added
  • Description modified (diff)

comment:3 Changed 5 months ago by mkoeppe

  • Branch set to u/mkoeppe/givaro_spkg_configure__reject_too_new_versions

comment:4 Changed 5 months ago by mkoeppe

  • Commit set to d2d73dca18273a0bec2c283d4095b4518aa41065
  • Dependencies set to #32947

New commits:

d2d73dcbuild/pkgs/givaro/spkg-configure.m4: Reject givaro >= 4.2.0

comment:5 Changed 5 months ago by git

  • Commit changed from d2d73dca18273a0bec2c283d4095b4518aa41065 to f8d5fa2747a70290b2b659c4684696094f7e83ff

Branch pushed to git repo; I updated commit sha1. New commits:

ab4fb99tox.ini: Add ubuntu-jammy, debian-bookworm, linuxmint-20.3, fedora-36
e51225a.github/workflows/tox*.yml: Remove debian-jessie, add ubuntu-jammy, debian-bookworm, linuxmint-20.3, fedora-36
ac47e7d.github/workflows/tox-gcc_spkg.yml: Remove
f8d5fa2Merge #32947

comment:6 Changed 5 months ago by mkoeppe

  • Description modified (diff)

comment:7 Changed 5 months ago by mkoeppe

  • Status changed from new to needs_review
tox -e docker-ubuntu-focal-standard -- config.status

correctly accept givaro 4.1.1

tox -e docker-debian-bookworm-standard -- config.status

correctly rejects givaro 4.2.0

comment:8 Changed 5 months ago by mkoeppe

  • Cc arojas added

comment:9 Changed 5 months ago by mkoeppe

  • Description modified (diff)

comment:10 Changed 5 months ago by mkoeppe

Let's get this in please.

comment:11 Changed 5 months ago by dimpase

  • Status changed from needs_review to needs_work
+    m4_pushdef([SAGE_GIVARO_LTVER])
     m4_popdef([SAGE_GIVARO_MINVER])

That should be popdef, obviously.

comment:12 Changed 5 months ago by git

  • Commit changed from f8d5fa2747a70290b2b659c4684696094f7e83ff to 1da5d3130eeeff9b6797dac2b347c34cc26290d7

Branch pushed to git repo; I updated commit sha1. New commits:

1da5d31build/pkgs/givaro/spkg-configure.m4: Fix typo

comment:13 Changed 5 months ago by mkoeppe

  • Status changed from needs_work to needs_review

comment:14 Changed 5 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

looks good to me

comment:15 Changed 5 months ago by mkoeppe

Thanks!

comment:16 Changed 5 months ago by vbraun

  • Branch changed from u/mkoeppe/givaro_spkg_configure__reject_too_new_versions to 1da5d3130eeeff9b6797dac2b347c34cc26290d7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.