Opened 14 months ago
Closed 11 months ago
#32965 closed enhancement (fixed)
tox / GH Actions: Add centos-7-devtoolset-gcc_{9,10,11}
Reported by: | Matthias Köppe | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | sage-9.6 |
Component: | porting | Keywords: | |
Cc: | Dima Pasechnik | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | d11dd6e (Commits, GitHub, GitLab) | Commit: | d11dd6e6578d84ceef2477747b2a5e52e1cd2f16 |
Dependencies: | #32966, #33306 | Stopgaps: |
Description (last modified by )
(from #30876)
centos-7
has EOL June 2024 and comes with the very outdated gcc 4.x, which we will not be able to use any more (see #32074)
We add variants centos-7-devtoolset-gcc_{9,10,11}
, following https://stackoverflow.com/a/67212990/557937; to test:
tox -e docker-centos-7-devtoolset-gcc_11-standard
This prepares a switch from centos-7
to centos-7-devtoolset-gcc_11
, as suggested by dimpase in https://trac.sagemath.org/ticket/30876#comment:12
("nobody nowadays is using gcc 4 on Centos 7... We can and should drop gcc 4, without dropping OSs")
(This is not needed for fedora
because even the oldest that we currently support, fedora-26
, comes with GCC 7.1.1.)
Change History (20)
comment:1 Changed 13 months ago by
Milestone: | sage-9.5 → sage-9.6 |
---|
comment:2 Changed 12 months ago by
Dependencies: | → #32966 |
---|
comment:3 Changed 12 months ago by
Description: | modified (diff) |
---|---|
Summary: | tox / GH Actions: Add fedora/centos variants using devtoolset → tox / GH Actions: Add centos-7-devtoolset-gcc_{9,10,11} |
comment:4 Changed 12 months ago by
Dependencies: | #32966 → #32966, #33306 |
---|
comment:5 Changed 12 months ago by
Authors: | → Matthias Koeppe |
---|
comment:6 Changed 12 months ago by
Branch: | → u/mkoeppe/tox___gh_actions__add_fedora_centos_variants_using_devtoolset |
---|
comment:7 Changed 12 months ago by
Commit: | → 9c8f6dbbb85791e1a83a933c04b48d282818f503 |
---|---|
Description: | modified (diff) |
Status: | new → needs_review |
comment:8 follow-up: 9 Changed 12 months ago by
comment:9 Changed 12 months ago by
Replying to dimpase:
testing this on https://github.com/sagemath/sagetrac-mirror/actions/runs/1818122556
That's not testing anything related to the ticket because I have not changed .github/workflows/tox.yml
comment:10 Changed 12 months ago by
OK, testing this now.
I wonder, by the way, whether it's possible to give docker images created meaningful names, and not these automatically assigned romantic_chebyshev
etc.
comment:11 follow-up: 12 Changed 12 months ago by
The images are already tagged with names such as sage-docker-centos-7-devtoolset-gcc_11-standard-with-targets
. Probably you mean containers. The ones created as a side effect of building the images in tox
do not matter.
If you run one of the built images in a new container using docker run -it sage-docker-centos-7-devtoolset-gcc_11-standard-with-targets:9.6.beta0-16-g9c8f6dbbb8-failed
or such, you can use an option --name
to give a name to the container.
comment:12 Changed 12 months ago by
Replying to mkoeppe:
The images are already tagged with names such as
sage-docker-centos-7-devtoolset-gcc_11-standard-with-targets
. Probably you mean containers. The ones created as a side effect of building the images intox
do not matter.
Well, they matter for debugging,say. And figuring this out by names might be a good idea.
comment:13 Changed 12 months ago by
No, these containers are dead. They have been committed to tagged images already. For debugging purposes, you run a new container from that image.
comment:14 Changed 12 months ago by
Reviewers: | → Dima Pasechnik |
---|---|
Status: | needs_review → positive_review |
OK, it works
comment:16 Changed 12 months ago by
Priority: | major → critical |
---|
comment:18 Changed 11 months ago by
Commit: | 9c8f6dbbb85791e1a83a933c04b48d282818f503 → d11dd6e6578d84ceef2477747b2a5e52e1cd2f16 |
---|---|
Status: | positive_review → needs_review |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
4e2d536 | build/bin/write-dockerfile.sh (ubuntu): Run apt-get update before installing software-properties-common
|
80057ba | Merge tag '9.6.beta0' into t/32966/tox___gh_actions__add_ubuntu_variants_using_ppa_ubuntu_toolchain_r
|
6bc45ce | build/bin/write-dockerfile.sh (debian) [EXTRA_REPOSITORY]: Also install gpg, gpg-agent
|
459749b | Merge #33187
|
983b4a8 | src/doc/en/developer/portability_testing.rst: Document RAM needs for Docker containers
|
a78c109 | Merge #33103
|
f98e0dc | build/bin/write-dockerfile.sh (debian) [EXTRA_REPOSITORY]: Do not fail if gpg, gpg-agent cannot be installed
|
d42bc03 | Merge tag '9.6.beta1' into t/32966/tox___gh_actions__add_ubuntu_variants_using_ppa_ubuntu_toolchain_r
|
d11dd6e | Merge #32966
|
comment:19 Changed 11 months ago by
Status: | needs_review → positive_review |
---|
comment:20 Changed 11 months ago by
Branch: | u/mkoeppe/tox___gh_actions__add_fedora_centos_variants_using_devtoolset → d11dd6e6578d84ceef2477747b2a5e52e1cd2f16 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Last 10 new commits:
build/pkgs/_prereq/distros/slackware.txt: Add packages needed on -current
tox.ini: Add centos-stream-{8,9
}tox.ini: Remove centos-6 (packages no longer available)
Merge tag '9.5' into t/33196/tox_ini__add_centos_stream8__stream9
Merge #33196
tox.ini (centos-8): Remove
.github/workflows/tox*.yml: Replace centos-8 by centos-stream-8
.github/workflows/tox*.yml: Replace opensuse-15 (same as opensuse-15.3) by opensuse-15.2.1
Merge #33306
tox.ini (centos-7-devtoolset): New