Opened 7 months ago
Closed 6 months ago
#32930 closed enhancement (fixed)
IPython/Jupyter upgrade for python 3.10 support
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | critical | Milestone: | sage-9.5 |
Component: | packages: standard | Keywords: | |
Cc: | enriqueartal, tornaria, egourgoulhon, klee, mjo | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Michael Orlitzky |
Report Upstream: | N/A | Work issues: | |
Branch: | 66c16b1 (Commits, GitHub, GitLab) | Commit: | 66c16b14f9081c6d62f5d105cfe76b470074c187 |
Dependencies: | Stopgaps: |
Description (last modified by )
All updated packages still support Python 3.7, as needed for the Sage 9.5 series.
Change History (16)
comment:1 Changed 7 months ago by
- Branch set to u/mkoeppe/ipython_jupyter_upgrade_for_python_3_10_support
comment:2 Changed 7 months ago by
- Commit set to 66c16b14f9081c6d62f5d105cfe76b470074c187
comment:3 Changed 7 months ago by
- Description modified (diff)
comment:4 Changed 7 months ago by
- Reviewers set to https://github.com/mkoeppe/sage/actions/runs/1502165423
- Status changed from new to needs_review
comment:5 Changed 7 months ago by
Tests look OK. Ready for review
comment:6 Changed 7 months ago by
Is a similar ticket needed for JupyterLab (optional package) too?
comment:7 Changed 7 months ago by
There's a separate ticket somewhere for that
comment:8 Changed 7 months ago by
Oh, #32069, I see.
comment:9 Changed 7 months ago by
- Cc egourgoulhon added
comment:10 Changed 7 months ago by
- Cc klee added
comment:11 Changed 7 months ago by
- Cc mjo added
I'm testing this along with #31535. I've run
$ EXTRA_CONFIGURE_ARGS="--without-system-python3" tox -e local-direct -- build sagelib-tox-python-sagewheels-nopypi
and I'm seeing doctest failures like
Failed example: shell = get_test_shell() Expected nothing Got: doctest:warning ... : UserWarning: Attempting to work in a virtualenv. If you encounter problems, please install IPython inside the virtualenv. Error processing line 1 of /home/mjo/src/sage.git/pkgs/sagemath-standard/.tox/python-sagewheels-nopypi/lib/python3.9/site-packages/_virtualenv.pth: <BLANKLINE> Traceback (most recent call last): File "/home/mjo/src/sage.git/.tox/local-direct/local/lib/python3.9/site.py", line 169, in addpackage exec(line) File "<string>", line 1, in <module> ModuleNotFoundError: No module named '_virtualenv' <BLANKLINE> Remainder of file ignored
Does that look like a tox issue, or something that changed with ipython?
comment:12 Changed 7 months ago by
I think this might be fixed with #32933
comment:13 Changed 7 months ago by
- Reviewers changed from https://github.com/mkoeppe/sage/actions/runs/1502165423 to Michael Orlitzky
- Status changed from needs_review to positive_review
Yep, looks like that was it.
comment:14 Changed 7 months ago by
Thanks for reviewing!
comment:15 Changed 7 months ago by
- Priority changed from major to critical
comment:16 Changed 6 months ago by
- Branch changed from u/mkoeppe/ipython_jupyter_upgrade_for_python_3_10_support to 66c16b14f9081c6d62f5d105cfe76b470074c187
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Last 10 new commits:
build/pkgs/ipywidgets: Update to 7.6.5
build/pkgs/jedi: Update to 0.18.1
build/pkgs/prompt_toolkit: Update to 3.0.22
build/pkgs/widgetsnbextension: Update to 3.5.2
build/pkgs/terminado: Update to 0.12.1
build/pkgs/notebook: Update to 6.4.6
build/pkgs/nbclient: Update to 0.5.4
build/pkgs/jupyter_client: Update to 7.1.0
build/pkgs/jupyter_core: Update to 4.9.1
build/pkgs/importlib_metadata: Update to 4.8.2