Opened 6 months ago

Closed 3 months ago

#32922 closed enhancement (fixed)

Change parameter name

Reported by: gh-thhagelmayer Owned by:
Priority: trivial Milestone: sage-9.6
Component: asymptotic expansions Keywords: asymptotics
Cc: behackl, cheuberg, dkrenn Merged in:
Authors: Thomas Hagelmayer Reviewers: Benjamin Hackl
Report Upstream: N/A Work issues:
Branch: bca6e35 (Commits, GitHub, GitLab) Commit: bca6e359aee3b89fb76281420f0f9a5aa280ec7d
Dependencies: #32278 Stopgaps:

Status badges

Description

Change parameter name to be more descriptive.

Change History (6)

comment:1 Changed 6 months ago by gh-thhagelmayer

  • Branch set to u/gh-thhagelmayer/change_parameter_name

comment:2 Changed 6 months ago by gh-thhagelmayer

  • Commit set to bca6e359aee3b89fb76281420f0f9a5aa280ec7d
  • Status changed from new to needs_review

I changed the parameter self to expression in: 

@staticmethod
    def B(expression, valid_from=0):
    ...
    return expression.B(valid_from)

Last 10 new commits:

​f7c1823Merge branch 't/32214/term-monoids-unify-repr' into t/32215/refactor-element-construction-term-monoids
​ba8efe6Merge branch 'u/gh-thhagelmayer/refactor-element-construction-term-monoids' of git://trac.sagemath.org/sage into t/32215/refactor-element-construction-term-monoids
​51e035fTrac #32215: fix doctests (due to merge of #32214)
​d763d66Trac #32215: full coverage of _element_constructor_
​540d088Merge commit 'c11b2f4' into t/32215/refactor-element-construction-term-monoids
​62cae10Trac #32215: fix doctest after merge
​a84a2f2Merge branch 'u/dkrenn/refactor-element-construction-term-monoids' of trac.sagemath.org:sage into t/32229/bterms_conversion
​84ad7a3Trac #32229: take absolute value of coefficient of BTerm
​2474870Merge branch 'u/behackl/bterms_conversion' of trac.sagemath.org:sage into t/32278/add_support_for_b_terms_in_asymptotic_ring
​bca6e35Trac #32922: Change parameter name to be more descriptive.

comment:3 Changed 6 months ago by gh-thhagelmayer

  • Type changed from defect to enhancement

comment:4 Changed 6 months ago by behackl

  • Reviewers set to Benjamin Hackl
  • Status changed from needs_review to positive_review

Semantically, this makes sense. LGTM.

comment:5 Changed 4 months ago by slelievre

  • Milestone changed from sage-9.5 to sage-9.6

Setting milestone to 9.6 now that 9.5 is out.

comment:6 Changed 3 months ago by vbraun

  • Branch changed from u/gh-thhagelmayer/change_parameter_name to bca6e359aee3b89fb76281420f0f9a5aa280ec7d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.