Opened 15 months ago

Closed 12 months ago

#32891 closed defect (fixed)

Unstable doctest geometry/hyperbolic_space/hyperbolic_model.py

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.6
Component: doctest framework Keywords:
Cc: Michael Orlitzky, Travis Scrimshaw, Javier Honrubia González Merged in:
Authors: Michael Orlitzky Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: eddded5 (Commits, GitHub, GitLab) Commit: eddded5fcfa1e342cd904041c2cfd012a76a85ea
Dependencies: Stopgaps:

Status badges

Description

Part of #32544: 

sage -t --long --random-seed=257293673212457698646690051018428858654 src/sage/geometry/hyperbolic_space/hyperbolic_model.py
**********************************************************************
File "src/sage/geometry/hyperbolic_space/hyperbolic_model.py", line 567, in sage.geometry.hyperbolic_space.hyperbolic_model.HyperbolicModel.random_geodesic
Failed example:
    bool((h.endpoints()[0].coordinates()).imag() >= 0)
Expected:
    True
Got:
    False
**********************************************************************
1 item had failures:
   1 of   3 in sage.geometry.hyperbolic_space.hyperbolic_model.HyperbolicModel.random_geodesic
    [234 tests, 1 failure, 0.77 s]
------------------------------------

Change History (6)

comment:1 Changed 13 months ago by Matthias Köppe

Milestone: sage-9.5 → sage-9.6

comment:2 Changed 13 months ago by Michael Orlitzky

Cc: Michael Orlitzky Travis Scrimshaw Javier Honrubia González added

Wild ass guess: this should be testing HyperbolicPlane().UHP() and not HyperbolicPlane().PD(). The former stands for Upper Half Plane, the latter for Poincare Disk.

comment:3 Changed 13 months ago by Travis Scrimshaw

Indeed, that test is only valid for the UHP, but that method is already being tested. Here, we should test that the absolute value is at most 1 to test in the PD model.

comment:4 Changed 13 months ago by Michael Orlitzky

Authors: → Michael Orlitzky
Branch: → u/mjo/ticket/32891
Commit: → eddded5fcfa1e342cd904041c2cfd012a76a85ea
Status: new → needs_review

New commits:

​eddded5Trac #32891: fix a failing hyperbolic model doctest.

comment:5 Changed 13 months ago by Travis Scrimshaw

Reviewers: → Travis Scrimshaw
Status: needs_review → positive_review

Thank you. LGTM.

comment:6 Changed 12 months ago by Volker Braun

Branch: u/mjo/ticket/32891 → eddded5fcfa1e342cd904041c2cfd012a76a85ea
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.