#32881 closed enhancement (fixed)

Feature for sage.rings.padics

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.6
Component: refactoring Keywords:
Cc: saraedum, klee, slabbe Merged in:
Authors: Matthias Koeppe Reviewers: Sébastien Labbé
Report Upstream: N/A Work issues:
Branch: 439db4b (Commits, GitHub, GitLab) Commit: 439db4b9893c5efcec79e822bf724484504d8b9d
Dependencies: #32174 Stopgaps:

Status badges


We introduce a feature for the presence of sage.rings.padics (not included, for example in https://pypi.org/project/sagemath-polyhedra/ (#32432).

We then mark some doctests in sage.structure and sage.misc as # optional - sage.rings.padics.

Change History (14)

comment:1 Changed 15 months ago by mkoeppe

Branch: u/mkoeppe/feature_for_sage_rings_padics

comment:2 Changed 15 months ago by git

Commit: b63c6c0c02b6e9e30273cfc06f39d27c5248a26b

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

00cb9c7src/sage/features/normaliz.py: Rename class to PyNormaliz, fix uses
7632e53src/sage/geometry/polyhedron/base.py: Remove unused import
24aaf73Merge #27744
b8f0a10src/sage/features/normaliz.py: Add all_features
944bb74src/sage/features/interfaces.py: Add doctests
2463e1eMerge #32866
91f0bccsrc/sage/doctest: Update doctest outputs
12f7c98src/sage/features/polymake.py: Add all_features
c9312dbsrc/sage/features: Add more all_features functions
b63c6c0Merge branch 't/32174/doctests__detect__safe__external_features_even_if____optional_external__is_not_used' into t/32881/feature_for_sage_rings_padics

comment:3 Changed 15 months ago by mkoeppe

Authors: Matthias Koeppe
Cc: saraedum added
Status: newneeds_review

comment:4 Changed 14 months ago by git

Commit: b63c6c0c02b6e9e30273cfc06f39d27c5248a26b439db4b9893c5efcec79e822bf724484504d8b9d

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

7a8f48csrc/sage/features/sagemath.py (sage_features): Unused now, removed
e7f538dsage.features.bliss: Change name of BlissLibrary feature to libbliss, remove it from all_features
12a2507src/sage/features/interfaces.py: Fix indentation in docstring
0dd76b6Merge tag '9.5.beta7' into t/32174/doctests__detect__safe__external_features_even_if____optional_external__is_not_used
07b2512src/sage/misc/latex.py: Conditionalize some doctests on latex_package_tkz_graph
cb1343732174: fix the --show-skipped doctest report
391dca1sage.misc.latex.png: Mark doctest # optional - imagemagick
6f311b3src/sage/doctest/external.py: Revert latex features to 'external'
3bfe1a132174: adapting the doctest listing external softwares
439db4bMerge #32174

comment:5 Changed 14 months ago by mkoeppe

Merged updated #32174

comment:6 Changed 14 months ago by mkoeppe

Cc: klee added

comment:7 Changed 14 months ago by mkoeppe

Milestone: sage-9.5sage-9.6

comment:8 Changed 13 months ago by mkoeppe

Cc: slabbe added

comment:9 Changed 13 months ago by slabbe

Copy pasting the command allowing to test the modified files here:

sage -tp src/sage/categories/fields.py src/sage/features/sagemath.py src/sage/misc/cachefunc.pyx src/sage/structure/factory.pyx src/sage/structure/parent.pyx src/sage/structure/richcmp.pxd src/sage/structure/sage_object.pyx
Last edited 13 months ago by slabbe (previous) (diff)

comment:10 Changed 13 months ago by slabbe

Looks good, I get this:

Doctesting 7 files using 8 threads.
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/features/sagemath.py
    [34 tests, 0.02 s]
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/structure/richcmp.pxd
    [24 tests, 0.02 s]
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/categories/fields.py
    [134 tests, 1.34 s]
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/structure/parent.pyx
    [383 tests, 2.96 s]
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/structure/factory.pyx
    [117 tests, 3.36 s]
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/structure/sage_object.pyx
    [119 tests, 3.65 s]
sage -t --random-seed=318677177718744620493039142226171694228 src/sage/misc/cachefunc.pyx
    [825 tests, 11.16 s]
All tests passed!
Total time for all tests: 11.3 seconds
    cpu time: 12.4 seconds
    cumulative wall time: 22.5 seconds
Features detected for doctesting: sage.combinat,sage.geometry.polyhedron,sage.graphs,sage.plot,sage.rings.number_field,sage.rings.padics,sage.rings.real_double,sage.symbolic
Pytest is not installed, skip checking tests that rely on it.

Note that sage.rings.padics appears in the list of detected Features.

Last edited 13 months ago by slabbe (previous) (diff)

comment:11 Changed 13 months ago by slabbe

Reviewers: Sébastien Labbé
Status: needs_reviewpositive_review

Patchbot is fine (only an irrelevant warning with respect to startup time).

comment:12 Changed 13 months ago by mkoeppe

Thank you and happy new year!

comment:13 Changed 13 months ago by slabbe

Happy new year to you to! I will continue to review few of your tickets for the year to come, slowly but surely.

comment:14 Changed 12 months ago by vbraun

Branch: u/mkoeppe/feature_for_sage_rings_padics439db4b9893c5efcec79e822bf724484504d8b9d
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.