Opened 15 months ago
Closed 12 months ago
#32881 closed enhancement (fixed)
Feature for sage.rings.padics
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sage9.6 
Component:  refactoring  Keywords:  
Cc:  saraedum, klee, slabbe  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Sébastien Labbé 
Report Upstream:  N/A  Work issues:  
Branch:  439db4b (Commits, GitHub, GitLab)  Commit:  439db4b9893c5efcec79e822bf724484504d8b9d 
Dependencies:  #32174  Stopgaps: 
Description
We introduce a feature for the presence of sage.rings.padics
(not included, for example in https://pypi.org/project/sagemathpolyhedra/ (#32432).
We then mark some doctests in sage.structure
and sage.misc
as # optional  sage.rings.padics
.
Change History (14)
comment:1 Changed 15 months ago by
Branch:  → u/mkoeppe/feature_for_sage_rings_padics 

comment:2 Changed 15 months ago by
Commit:  → b63c6c0c02b6e9e30273cfc06f39d27c5248a26b 

comment:3 Changed 15 months ago by
Authors:  → Matthias Koeppe 

Cc:  saraedum added 
Status:  new → needs_review 
comment:4 Changed 14 months ago by
Commit:  b63c6c0c02b6e9e30273cfc06f39d27c5248a26b → 439db4b9893c5efcec79e822bf724484504d8b9d 

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
7a8f48c  src/sage/features/sagemath.py (sage_features): Unused now, removed

e7f538d  sage.features.bliss: Change name of BlissLibrary feature to libbliss, remove it from all_features

12a2507  src/sage/features/interfaces.py: Fix indentation in docstring

0dd76b6  Merge tag '9.5.beta7' into t/32174/doctests__detect__safe__external_features_even_if____optional_external__is_not_used

07b2512  src/sage/misc/latex.py: Conditionalize some doctests on latex_package_tkz_graph

cb13437  32174: fix the showskipped doctest report

391dca1  sage.misc.latex.png: Mark doctest # optional  imagemagick

6f311b3  src/sage/doctest/external.py: Revert latex features to 'external'

3bfe1a1  32174: adapting the doctest listing external softwares

439db4b  Merge #32174

comment:6 Changed 14 months ago by
Cc:  klee added 

comment:7 Changed 14 months ago by
Milestone:  sage9.5 → sage9.6 

comment:8 Changed 13 months ago by
Cc:  slabbe added 

comment:9 Changed 13 months ago by
Copy pasting the command allowing to test the modified files here:
sage tp src/sage/categories/fields.py src/sage/features/sagemath.py src/sage/misc/cachefunc.pyx src/sage/structure/factory.pyx src/sage/structure/parent.pyx src/sage/structure/richcmp.pxd src/sage/structure/sage_object.pyx
comment:10 Changed 13 months ago by
Looks good, I get this:
Doctesting 7 files using 8 threads. sage t randomseed=318677177718744620493039142226171694228 src/sage/features/sagemath.py [34 tests, 0.02 s] sage t randomseed=318677177718744620493039142226171694228 src/sage/structure/richcmp.pxd [24 tests, 0.02 s] sage t randomseed=318677177718744620493039142226171694228 src/sage/categories/fields.py [134 tests, 1.34 s] sage t randomseed=318677177718744620493039142226171694228 src/sage/structure/parent.pyx [383 tests, 2.96 s] sage t randomseed=318677177718744620493039142226171694228 src/sage/structure/factory.pyx [117 tests, 3.36 s] sage t randomseed=318677177718744620493039142226171694228 src/sage/structure/sage_object.pyx [119 tests, 3.65 s] sage t randomseed=318677177718744620493039142226171694228 src/sage/misc/cachefunc.pyx [825 tests, 11.16 s]  All tests passed!  Total time for all tests: 11.3 seconds cpu time: 12.4 seconds cumulative wall time: 22.5 seconds Features detected for doctesting: sage.combinat,sage.geometry.polyhedron,sage.graphs,sage.plot,sage.rings.number_field,sage.rings.padics,sage.rings.real_double,sage.symbolic Pytest is not installed, skip checking tests that rely on it.
Note that sage.rings.padics
appears in the list of detected Features.
comment:11 Changed 13 months ago by
Reviewers:  → Sébastien Labbé 

Status:  needs_review → positive_review 
Patchbot is fine (only an irrelevant warning with respect to startup time).
comment:13 Changed 13 months ago by
Happy new year to you to! I will continue to review few of your tickets for the year to come, slowly but surely.
comment:14 Changed 12 months ago by
Branch:  u/mkoeppe/feature_for_sage_rings_padics → 439db4b9893c5efcec79e822bf724484504d8b9d 

Resolution:  → fixed 
Status:  positive_review → closed 
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
src/sage/features/normaliz.py: Rename class to PyNormaliz, fix uses
src/sage/geometry/polyhedron/base.py: Remove unused import
Merge #27744
src/sage/features/normaliz.py: Add all_features
src/sage/features/interfaces.py: Add doctests
Merge #32866
src/sage/doctest: Update doctest outputs
src/sage/features/polymake.py: Add all_features
src/sage/features: Add more all_features functions
Merge branch 't/32174/doctests__detect__safe__external_features_even_if____optional_external__is_not_used' into t/32881/feature_for_sage_rings_padics