#32880 closed defect (fixed)

Replace Singular example with GAP in _get_shared_lib_path()

Reported by: Michael Orlitzky Owned by:
Priority: major Milestone: sage-9.5
Component: misc Keywords:
Cc: Merged in:
Authors: Michael Orlitzky Reviewers: Gonzalo Tornaría
Report Upstream: N/A Work issues:
Branch: 17e308f (Commits, GitHub, GitLab) Commit: 17e308fd9d56d022ed28592f93f07ec8dce530ef
Dependencies: Stopgaps:

Status badges

Description (last modified by Michael Orlitzky)

We still have a doctest for _get_shared_lib_path() that ensures it can find libSingular. However,

  1. the premise behind _get_shared_lib_path() does not make sense; you can't just guess where a library comes from
  2. as a result of (1), it's failing to find libSingular in some cases; but thankfully
  3. we no longer care if it can find libSingular, because the full path to libSingular is contained in LIBSINGULAR_PATH

Instead we should have it look for libgap, because gap is still installed from an SPKG, and we can ensure that it's installed in just the right way for _get_shared_lib_path() to find it. Moreover, we actually call the function with "gap" as an argument, so there's that.

Reported in https://trac.sagemath.org/ticket/29024#comment:168

Change History (4)

comment:1 Changed 13 months ago by Michael Orlitzky

Description: modified (diff)

comment:2 Changed 13 months ago by Michael Orlitzky

Authors: Michael Orlitzky
Branch: u/mjo/ticket/32880
Commit: 17e308fd9d56d022ed28592f93f07ec8dce530ef
Status: newneeds_review

New commits:

17e308fTrac #32880: use GAP instead of Singular to test _get_shared_lib_path().

comment:3 Changed 13 months ago by Gonzalo Tornaría

Reviewers: Gonzalo Tornaría
Status: needs_reviewpositive_review

Looks good to me. I took the patch for the sagemath package for void linux (wip) which uses system singular, and the failing doctest now passes.

See ​https://github.com/void-linux/void-packages/pull/34030

comment:4 Changed 12 months ago by Volker Braun

Branch: u/mjo/ticket/3288017e308fd9d56d022ed28592f93f07ec8dce530ef
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.