#32869 closed defect (fixed)

fix improper names of several special functions for CBF

Reported by: Dima Pasechnik Owned by:
Priority: major Milestone: sage-9.5
Component: symbolics Keywords:
Cc: Merged in:
Authors: Marc Mezzarobba Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: d9ee935 (Commits, GitHub, GitLab) Commit: d9ee935f95001716b8493be7689b4e3b52b1afc5
Dependencies: Stopgaps:

Status badges

Description

CBF, i.e. sage/rings/complex_arb.pyx, names functions such as Ei impoperly, as ei. This in particular makes it impossible to do e.g. CBF(Ei(I)) (one gets infinite recursion error).

The fix is just to rename them. One can first set aliases Ei = ei, etc., and deprecate ei, and then, after the deprecation period, do the renaming.

Change History (5)

comment:1 Changed 13 months ago by Marc Mezzarobba

The names of the symbolic functions are also inconsistent: Ei is Ei, but Si, etc. are actually aliases for sin_integral, etc.

comment:2 Changed 13 months ago by Marc Mezzarobba

Authors: Marc Mezzarobba
Branch: u/mmezzarobba/CBF_renamespecfuns
Commit: d9ee935f95001716b8493be7689b4e3b52b1afc5
Status: newneeds_review

see #32871 for the infinite recursion


New commits:

d9ee935#32869 ComplexBall: rename + add aliases for some special functions

comment:3 Changed 13 months ago by Dima Pasechnik

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

lgtm

comment:4 Changed 13 months ago by Marc Mezzarobba

thank you!

comment:5 Changed 13 months ago by Volker Braun

Branch: u/mmezzarobba/CBF_renamespecfunsd9ee935f95001716b8493be7689b4e3b52b1afc5
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.