Opened 8 months ago

Closed 8 months ago

#32844 closed enhancement (fixed)

fix some details in sloane_functions

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.5
Component: combinatorics Keywords:
Cc: tscrim, slelievre, gh-kliem Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 22235af (Commits, GitHub, GitLab) Commit: 22235afa31d10b17c2c05276b6ca573e4d53a04d
Dependencies: Stopgaps:

Status badges

Description

namely a few lgtm warnings and some pep8 suggestions

Change History (5)

comment:1 Changed 8 months ago by chapoton

  • Branch set to u/chapoton/32844
  • Commit set to 22235afa31d10b17c2c05276b6ca573e4d53a04d
  • Status changed from new to needs_review

New commits:

22235affix some lgtm and pep details in sloane_functions.py

comment:2 Changed 8 months ago by chapoton

  • Cc tscrim slelievre gh-kliem added

lights are morally green, so please review

comment:3 Changed 8 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 8 months ago by slelievre

A follow-up ticket could change

-        return arith.lcm([i for i in range(1, n+1)])
+        return arith.lcm(range(1, n+1))

Other [a for a in range(b)] that grep can reveal could become range(b) or list(range(b)).

comment:5 Changed 8 months ago by vbraun

  • Branch changed from u/chapoton/32844 to 22235afa31d10b17c2c05276b6ca573e4d53a04d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.