Opened 11 years ago

Closed 11 years ago

#3278 closed defect (fixed)

[with patch, positive review] update the crystal iterator to use the new backtracking code

Reported by: mhansen Owned by: mhansen
Priority: minor Milestone: sage-3.0.3
Component: combinatorics Keywords:
Cc: sage-combinat Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description


Attachments (1)

3278.patch (5.3 KB) - added by mhansen 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by mhansen

comment:1 Changed 11 years ago by ddrake

  • Summary changed from [with patch, needs review] update the crystal iterator to use the new backtracking code to [with patch, positive review with caveat] update the crystal iterator to use the new backtracking code

Positive review, with one caveat: I didn't actually apply the patch and run the tests, because my Sage tree is messed up at the moment. mhansen on IRC said the tests pass...however, "because he said so on IRC" is an insult to the whole idea of review, so I feel like I should offer that warning. :)

comment:2 Changed 11 years ago by mabshoff

  • Cc sage-combinat added
  • Summary changed from [with patch, positive review with caveat] update the crystal iterator to use the new backtracking code to [with patch, positive review] update the crystal iterator to use the new backtracking code

I applied the patch to my merge tree and "-testall -long" passed. Positive review.

Cheers,

Michael

comment:3 Changed 11 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.3.alpha0

Note: See TracTickets for help on using tickets.