Opened 7 months ago

Closed 6 months ago

#32778 closed enhancement (fixed)

sage.rings.infinity: Remove hard dependency on real_lazy and real_mpfi

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.5
Component: refactoring Keywords:
Cc: dimpase Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: fb9faa6 (Commits, GitHub, GitLab) Commit: fb9faa69e62b5af763c6116815eb01f6c6b8d255
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

This is for sagemath-polyhedra (#32432).

Change History (11)

comment:1 Changed 7 months ago by mkoeppe

  • Summary changed from sage.rings.infinity: Remove hard dependency on real_lazy to sage.rings.infinity: Remove hard dependency on real_lazy and real_mpfi

comment:2 Changed 7 months ago by mkoeppe

  • Branch set to u/mkoeppe/sage_rings_infinity__remove_hard_dependency_on_real_lazy

comment:3 Changed 7 months ago by mkoeppe

  • Commit set to afe634c3d05c6b976ee199b7220f3e366f2d25fd
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

​afe634csage.rings.infinity: Remove hard dependency on real_lazy and real_mpfi

comment:4 Changed 7 months ago by mkoeppe

  • Status changed from needs_review to needs_work

comment:5 Changed 7 months ago by git

  • Commit changed from afe634c3d05c6b976ee199b7220f3e366f2d25fd to fb9faa69e62b5af763c6116815eb01f6c6b8d255

Branch pushed to git repo; I updated commit sha1. New commits:

​fb9faa6src/sage/rings/infinity.py: Fix up: Only call .parent() on elements

comment:6 Changed 7 months ago by mkoeppe

  • Status changed from needs_work to needs_review

comment:7 Changed 6 months ago by mkoeppe

one green patchbot, one patchbot that was not feeling well

ready for review

comment:8 Changed 6 months ago by mkoeppe

  • Cc dimpase added

comment:9 Changed 6 months ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

lgtm

comment:10 Changed 6 months ago by mkoeppe

Thank you!

comment:11 Changed 6 months ago by vbraun

  • Branch changed from u/mkoeppe/sage_rings_infinity__remove_hard_dependency_on_real_lazy to fb9faa69e62b5af763c6116815eb01f6c6b8d255
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.