Opened 16 months ago
Closed 15 months ago
#32764 closed enhancement (fixed)
SAGE_ROOT/tox.ini: Make tox -p auto and tox --listenvs useful again
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.5 |
Component: | porting | Keywords: | |
Cc: | jhpalmieri, gh-kliem | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | John Palmieri |
Report Upstream: | N/A | Work issues: | |
Branch: | 47a2b42 (Commits, GitHub, GitLab) | Commit: | 47a2b421fb70095a0971d37c39689460c0b16d4c |
Dependencies: | Stopgaps: |
Description (last modified by )
(from #29146)
tox does not actually understand the nested braces used in envlist
.
https://groups.google.com/g/sage-devel/c/NU-xlUTIIdE/m/Q14HiKvNAgAJ
Change History (13)
comment:1 Changed 16 months ago by
Description: | modified (diff) |
---|
comment:2 Changed 16 months ago by
Authors: | → Matthias Koeppe |
---|
comment:3 Changed 16 months ago by
Branch: | → u/mkoeppe/sage_root_tox_ini__make_tox__p_auto_and_tox___listenvs_useful_again |
---|
comment:4 Changed 16 months ago by
Commit: | → 5392cd7925de2eb58b349b8fcc26b5cf71d46eb3 |
---|
comment:5 Changed 16 months ago by
Here's an attempt at improving the tox -p auto
situation and documentation.
Please feel free to push further changes to this ticket
comment:6 Changed 16 months ago by
Commit: | 5392cd7925de2eb58b349b8fcc26b5cf71d46eb3 → 47a2b421fb70095a0971d37c39689460c0b16d4c |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
47a2b42 | tox.ini: Add more examples
|
comment:7 Changed 16 months ago by
Status: | new → needs_review |
---|
comment:8 Changed 15 months ago by
Cc: | gh-kliem added |
---|
comment:9 Changed 15 months ago by
Was the hope that the nested braces would allow testing all of the various combinations via tox -p auto
?
comment:10 Changed 15 months ago by
Yes, and some early version of it did something like that. https://tox.wiki/en/latest/config.html#generative-section-names Not sure if nesting ever worked.
comment:11 Changed 15 months ago by
Reviewers: | → John Palmieri |
---|---|
Status: | needs_review → positive_review |
I could imagine expanding that environment list (since it's much shorter now than the original intention), but that can wait.
comment:13 Changed 15 months ago by
Branch: | u/mkoeppe/sage_root_tox_ini__make_tox__p_auto_and_tox___listenvs_useful_again → 47a2b421fb70095a0971d37c39689460c0b16d4c |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Branch pushed to git repo; I updated commit sha1. New commits:
tox.ini: Do not include the environments delegated to src/tox.ini in 'tox -p auto'