Opened 9 months ago

Closed 8 months ago

Last modified 8 months ago

#32713 closed enhancement (fixed)

Apply "configure --enable-editable" also to other sage distribution packages

Reported by: gh-tobiasdiez Owned by:
Priority: major Milestone: sage-9.5
Component: build Keywords:
Cc: mkoeppe Merged in:
Authors: Tobias Diez Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 7bd6ce4 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

Enables editable mode also for sage-conf, sage-docbuild, sage-setup.

Change History (12)

comment:1 Changed 9 months ago by gh-tobiasdiez

  • Status changed from new to needs_review

comment:2 follow-up: Changed 9 months ago by mkoeppe

To match with the other functions in sage-dist-helpers, sdh_pip_editable_install should do its own error handling

comment:3 Changed 9 months ago by git

  • Commit changed from b9b1dba57d85ea7d6f68471024406a939579b5bb to a257621c3b3aa7e4d245a691dffbc67e6e45f08b

Branch pushed to git repo; I updated commit sha1. New commits:

a257621Add error handling

comment:4 in reply to: ↑ 2 Changed 9 months ago by gh-tobiasdiez

Replying to mkoeppe:

To match with the other functions in sage-dist-helpers, sdh_pip_editable_install should do its own error handling

Done

comment:5 Changed 8 months ago by gh-tobiasdiez

Do you have any further suggestions or can this go in?

comment:6 Changed 8 months ago by git

  • Commit changed from a257621c3b3aa7e4d245a691dffbc67e6e45f08b to 7bd6ce4f39bb8e3a94ba59eaf064044a1e02b9ee

Branch pushed to git repo; I updated commit sha1. New commits:

89bc3eeMerge branch 'develop' of git://github.com/sagemath/sage into public/build/inplace_ext
7bd6ce4Partly revert "Enable editable mode also for other sage packages"

comment:7 Changed 8 months ago by mkoeppe

  • Description modified (diff)
  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review
  • Summary changed from Enable editable mode also for other sage packages to Apply "configure --enable-editable" also to other sage distribution packages

This works well, thanks

comment:8 Changed 8 months ago by gh-tobiasdiez

Thanks for the review!

comment:9 Changed 8 months ago by mkoeppe

  • Priority changed from minor to major

comment:10 Changed 8 months ago by vbraun

  • Branch changed from public/build/inplace_ext to 7bd6ce4f39bb8e3a94ba59eaf064044a1e02b9ee
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:11 Changed 8 months ago by mkoeppe

  • Commit 7bd6ce4f39bb8e3a94ba59eaf064044a1e02b9ee deleted

Of course using --enable-editable now means that no sage_conf wheel is built any more! Which breaks tests such as ./sage -sh -c '(cd pkgs/sagemath-standard && tox -v -v -v -e python-sagewheels-nopypi)'.

comment:12 Changed 8 months ago by mkoeppe

Followup = #32913.

Note: See TracTickets for help on using tickets.