Opened 7 months ago
Closed 7 months ago
#32708 closed enhancement (fixed)
sage.tensor.modules: remove dependency on sage.manifolds
Reported by: | egourgoulhon | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.5 |
Component: | manifolds | Keywords: | tensor display |
Cc: | mkoeppe, tscrim | Merged in: | |
Authors: | Eric Gourgoulhon | Reviewers: | Matthias Koeppe |
Report Upstream: | N/A | Work issues: | |
Branch: | 1635bd3 (Commits, GitHub, GitLab) | Commit: | 1635bd3713a426939202e098e515ed5258485ab5 |
Dependencies: | Stopgaps: |
Description
In view of Sage modularization, this ticket removes the only import from sage.manifolds
in the module sage.tensor.modules
.
This was an import of Chart
in FreeModuleTensor._preparse_display
. This is avoided by reimplementing _preparse_display
in TensorFieldParal
.
Change History (4)
comment:1 Changed 7 months ago by
- Branch set to public/manifolds/no_chart_import_in_tensor_modules-32708
- Cc mkoeppe tscrim added
- Commit set to 1635bd3713a426939202e098e515ed5258485ab5
- Status changed from new to needs_review
comment:2 Changed 7 months ago by
- Reviewers set to Matthias Koeppe
- Status changed from needs_review to positive_review
comment:3 Changed 7 months ago by
Thank you for the review!
comment:4 Changed 7 months ago by
- Branch changed from public/manifolds/no_chart_import_in_tensor_modules-32708 to 1635bd3713a426939202e098e515ed5258485ab5
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Remove import of Chart in sage.tensor.modules (#32708)