#32708 closed enhancement (fixed)

sage.tensor.modules: remove dependency on sage.manifolds

Reported by: Eric Gourgoulhon Owned by:
Priority: major Milestone: sage-9.5
Component: manifolds Keywords: tensor display
Cc: Matthias Köppe, Travis Scrimshaw Merged in:
Authors: Eric Gourgoulhon Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 1635bd3 (Commits, GitHub, GitLab) Commit: 1635bd3713a426939202e098e515ed5258485ab5
Dependencies: Stopgaps:

Status badges


In view of Sage modularization, this ticket removes the only import from sage.manifolds in the module sage.tensor.modules. This was an import of Chart in FreeModuleTensor._preparse_display. This is avoided by reimplementing _preparse_display in TensorFieldParal.

Change History (4)

comment:1 Changed 14 months ago by Eric Gourgoulhon

Branch: public/manifolds/no_chart_import_in_tensor_modules-32708
Cc: Matthias Köppe Travis Scrimshaw added
Commit: 1635bd3713a426939202e098e515ed5258485ab5
Status: newneeds_review

New commits:

1635bd3Remove import of Chart in sage.tensor.modules (#32708)

comment:2 Changed 14 months ago by Matthias Köppe

Reviewers: Matthias Koeppe
Status: needs_reviewpositive_review

comment:3 Changed 14 months ago by Eric Gourgoulhon

Thank you for the review!

comment:4 Changed 14 months ago by Volker Braun

Branch: public/manifolds/no_chart_import_in_tensor_modules-327081635bd3713a426939202e098e515ed5258485ab5
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.