#32626 closed defect (fixed)

ipykernel: Missing dependency argcomplete for Python 3.7; remove obsolete scandir package

Reported by: Matthias Köppe Owned by:
Priority: critical Milestone: sage-9.5
Component: packages: standard Keywords:
Cc: gh-kliem Merged in:
Authors: Matthias Koeppe Reviewers: Jonathan Kliem
Report Upstream: N/A Work issues:
Branch: b09693d (Commits, GitHub, GitLab) Commit: b09693dfae08f6844a81aac89f157456105eb630
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

From https://github.com/ipython/ipykernel/blob/v6.3.1/setup.py:

install_requires=[
        "ipython_genutils",
        'importlib-metadata<5;python_version<"3.8.0"',
        'argcomplete>=1.12.3;python_version<"3.8.0"',

Change History (8)

comment:1 Changed 14 months ago by Matthias Köppe

Branch: u/mkoeppe/ipykernel__missing_dependency_argcomplete_for_python_3_7

comment:2 Changed 14 months ago by Matthias Köppe

Authors: Matthias Koeppe
Commit: 1c95bac06729b644ff019cee01518a8e0bcd49c4
Status: newneeds_review

New commits:

f0bc1b4build/pkgs/argcomplete: New
1c95bacbuild/pkgs/ipykernel/dependencies: Add argcomplete and other missing deps

comment:3 Changed 14 months ago by gh-kliem

Reviewers: Jonathan Kliem

Works like a charm.

Why is scandir a dependency?

comment:4 Changed 14 months ago by Matthias Köppe

Looks like scandir is obsolete for all supported Python versions - https://pypi.org/project/scandir/

Let's get rid of it

comment:5 Changed 14 months ago by git

Commit: 1c95bac06729b644ff019cee01518a8e0bcd49c4b09693dfae08f6844a81aac89f157456105eb630

Branch pushed to git repo; I updated commit sha1. New commits:

b09693dbuild/pkgs/scandir: Remove

comment:6 Changed 14 months ago by Matthias Köppe

Description: modified (diff)
Summary: ipykernel: Missing dependency argcomplete for Python 3.7ipykernel: Missing dependency argcomplete for Python 3.7; remove obsolete scandir package

comment:7 Changed 14 months ago by gh-kliem

Status: needs_reviewpositive_review

Thank you for the quick fix.

comment:8 Changed 14 months ago by Volker Braun

Branch: u/mkoeppe/ipykernel__missing_dependency_argcomplete_for_python_3_7b09693dfae08f6844a81aac89f157456105eb630
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.