Changes between Version 4 and Version 5 of Ticket #32560


Ignore:
Timestamp:
10/14/21 14:13:48 (9 months ago)
Author:
gh-LaisRast
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #32560

    • Property Status changed from new to needs_review
    • Property Authors changed from to Laith Rastanawi
    • Property Branch changed from to public/32560
    • Property Commit changed from to 36813911e27d5c31842016a28fe582c03e28497a

  • Ticket #32560 – Description

    v4 v5  
    99
    1010This behavior is unexpected since the user provided the scaling they want.
    11 ~~This behavior is also not documented. ~~I looked into the file `threejs_template.html` and I found the lines responsible for this behavior:
     11I looked into the file `threejs_template.html` and I found the lines responsible for this behavior:
    1212{{{
    1313    var autoAspect = 2.5;
    … …  
    1515}}}
    1616
    17 It turned out that the autmatic scaling was introduced in #12402. I quote the following text from that ticket:
     17It turned out that the automatic scaling was introduced in #12402. I quote the following text from that ticket:
    1818>  There is already automatic scaling in the z-direction to avoid the tall thin box that appears in the current version on the cell server (and SMC), but that can easily be overridden.
    1919
    … …  
    2424}}}
    2525
    26 I suggest to remove these 2 lines from the file,
    27 ~~or at the least, document it so the user can expect this behavior.~~
     26This ticket overwrites this behavior and introduces a new threejs-specific plot option.
     27The new option is called  `auto_scaling` (default: [False, False, False]) which is a list
     28or a tuple of three booleans; set to `True` to automatically scale down the corresponding
     29direction if it is too large.