Opened 8 weeks ago

Closed 6 weeks ago

#32449 closed defect (fixed)

Repair doctests for system giac 1.7

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.5
Component: packages: standard Keywords:
Cc: arojas, chapoton, dimpase, frederichan, parisse, slabbe, slelievre Merged in:
Authors: Antonio Rojas Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 7d6a7b8 (Commits, GitHub, GitLab) Commit: 7d6a7b82886827480d8ef4664c0e484cb669aa1d
Dependencies: Stopgaps:

Status badges

Change History (4)

comment:1 Changed 8 weeks ago by arojas

  • Branch set to u/arojas/repair_doctests_for_system_giac_1_7

comment:2 Changed 8 weeks ago by arojas

  • Authors set to Antonio Rojas
  • Commit set to 7d6a7b82886827480d8ef4664c0e484cb669aa1d
  • Status changed from new to needs_review

Using a wildcard since this is only testing that it doesn't throw an error.

I don't know how to test that the answer is correct in a way that works with both giac versions: testing that the derivative equals sqrt(x+sqrt(x)) fails with old giac (but works with 1.7)

New commits:

7d6a7b8Make test pass with giac 1.7

comment:3 Changed 8 weeks ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, good enough

comment:4 Changed 6 weeks ago by vbraun

  • Branch changed from u/arojas/repair_doctests_for_system_giac_1_7 to 7d6a7b82886827480d8ef4664c0e484cb669aa1d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.