Opened 9 months ago
Closed 8 months ago
#32415 closed enhancement (fixed)
Remove unnecessary uses of symbolic functions in sage.tensor.modules
| Reported by: | mkoeppe | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-9.5 |
| Component: | refactoring | Keywords: | |
| Cc: | egourgoulhon, gh-mjungmath, chapoton | Merged in: | |
| Authors: | Matthias Koeppe | Reviewers: | Eric Gourgoulhon |
| Report Upstream: | N/A | Work issues: | |
| Branch: | ac82dd2 (Commits, GitHub, GitLab) | Commit: | ac82dd2d27550267fde7552d10567d585822bab4 |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
Change History (7)
comment:1 Changed 9 months ago by
- Branch set to u/mkoeppe/remove_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_tensor_modules
comment:2 Changed 9 months ago by
- Cc egourgoulhon gh-mjungmath chapoton added
- Commit set to ac82dd2d27550267fde7552d10567d585822bab4
- Description modified (diff)
- Status changed from new to needs_review
- Summary changed from Remove unnecessary uses of SR and symbolic functions in sage.tensor.modules to Remove unnecessary uses of symbolic functions in sage.tensor.modules
comment:3 follow-up: ↓ 4 Changed 9 months ago by
LGTM. Just waiting for the patchbot...
comment:4 in reply to: ↑ 3 Changed 9 months ago by
- Reviewers set to Eric Gourgoulhon
- Status changed from needs_review to positive_review
Replying to egourgoulhon:
LGTM. Just waiting for the patchbot...
It came and is all green! Thanks for the ticket.
comment:5 Changed 9 months ago by
Thanks for the review!
comment:7 Changed 8 months ago by
- Branch changed from u/mkoeppe/remove_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_tensor_modules to ac82dd2d27550267fde7552d10567d585822bab4
- Resolution set to fixed
- Status changed from needs_work to closed
Note: See
TracTickets for help on using
tickets.
New commits:
sage.tensor.modules: Remove unnecessary uses of symbolic functions