Opened 2 months ago

Closed 6 weeks ago

#32415 closed enhancement (fixed)

Remove unnecessary uses of symbolic functions in sage.tensor.modules

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.5
Component: refactoring Keywords:
Cc: egourgoulhon, gh-mjungmath, chapoton Merged in:
Authors: Matthias Koeppe Reviewers: Eric Gourgoulhon
Report Upstream: N/A Work issues:
Branch: ac82dd2 (Commits, GitHub, GitLab) Commit: ac82dd2d27550267fde7552d10567d585822bab4
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

Similar to what is done in #32411.

This is part of Meta-ticket #29705 (modularization) - to remove unnecessary dependencies on the distribution sagemath-symbolics (#31695)

Change History (7)

comment:1 Changed 2 months ago by mkoeppe

  • Branch set to u/mkoeppe/remove_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_tensor_modules

comment:2 Changed 2 months ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc egourgoulhon gh-mjungmath chapoton added
  • Commit set to ac82dd2d27550267fde7552d10567d585822bab4
  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from Remove unnecessary uses of SR and symbolic functions in sage.tensor.modules to Remove unnecessary uses of symbolic functions in sage.tensor.modules

New commits:

ac82dd2sage.tensor.modules: Remove unnecessary uses of symbolic functions

comment:3 follow-up: Changed 2 months ago by egourgoulhon

LGTM. Just waiting for the patchbot...

comment:4 in reply to: ↑ 3 Changed 8 weeks ago by egourgoulhon

  • Reviewers set to Eric Gourgoulhon
  • Status changed from needs_review to positive_review

Replying to egourgoulhon:

LGTM. Just waiting for the patchbot...

It came and is all green! Thanks for the ticket.

comment:5 Changed 8 weeks ago by mkoeppe

Thanks for the review!

comment:6 Changed 7 weeks ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:7 Changed 6 weeks ago by vbraun

  • Branch changed from u/mkoeppe/remove_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_tensor_modules to ac82dd2d27550267fde7552d10567d585822bab4
  • Resolution set to fixed
  • Status changed from needs_work to closed
Note: See TracTickets for help on using tickets.