#32415 closed enhancement (fixed)

Remove unnecessary uses of symbolic functions in sage.tensor.modules

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.5
Component: refactoring Keywords:
Cc: Eric Gourgoulhon, Michael Jung, Frédéric Chapoton Merged in:
Authors: Matthias Koeppe Reviewers: Eric Gourgoulhon
Report Upstream: N/A Work issues:
Branch: ac82dd2 (Commits, GitHub, GitLab) Commit: ac82dd2d27550267fde7552d10567d585822bab4
Dependencies: Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

Similar to what is done in #32411.

This is part of Meta-ticket #29705 (modularization) - to remove unnecessary dependencies on the distribution sagemath-symbolics (#31695)

Change History (7)

comment:1 Changed 16 months ago by Matthias Köppe

Branch: u/mkoeppe/remove_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_tensor_modules

comment:2 Changed 16 months ago by Matthias Köppe

Authors: Matthias Koeppe
Cc: Eric Gourgoulhon Michael Jung Frédéric Chapoton added
Commit: ac82dd2d27550267fde7552d10567d585822bab4
Description: modified (diff)
Status: newneeds_review
Summary: Remove unnecessary uses of SR and symbolic functions in sage.tensor.modulesRemove unnecessary uses of symbolic functions in sage.tensor.modules

New commits:

ac82dd2sage.tensor.modules: Remove unnecessary uses of symbolic functions

comment:3 Changed 16 months ago by Eric Gourgoulhon

LGTM. Just waiting for the patchbot...

comment:4 in reply to:  3 Changed 15 months ago by Eric Gourgoulhon

Reviewers: Eric Gourgoulhon
Status: needs_reviewpositive_review

Replying to egourgoulhon:

LGTM. Just waiting for the patchbot...

It came and is all green! Thanks for the ticket.

comment:5 Changed 15 months ago by Matthias Köppe

Thanks for the review!

comment:6 Changed 15 months ago by Volker Braun

Status: positive_reviewneeds_work

Merge conflict

comment:7 Changed 15 months ago by Volker Braun

Branch: u/mkoeppe/remove_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_tensor_modulesac82dd2d27550267fde7552d10567d585822bab4
Resolution: fixed
Status: needs_workclosed
Note: See TracTickets for help on using tickets.