Opened 18 months ago
Closed 17 months ago
#32403 closed enhancement (fixed)
tox.yml: Use --enable-download-from-upstream-url for make dist
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-9.5 |
Component: | scripts | Keywords: | |
Cc: | mkoeppe, slelievre, gh-DaveWitteMorris, gh-kliem, dimpase | Merged in: | |
Authors: | Frédéric Chapoton, Matthias Koeppe | Reviewers: | Matthias Koeppe, Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | 33e43d5 (Commits, GitHub, GitLab) | Commit: | 33e43d57c6e8118afe892fad0c1a4a32c536ad7a |
Dependencies: | Stopgaps: |
Description (last modified by )
This removes the unpleasant failures of the dist
job for tickets that add/update packages; and thus enables the local-macos-nohomebrew
workflow for those.
The previous function of the dist
job to check whether all SPKG tarballs have been uploaded is now taken over by a new standalone workflow (sdist.yml
); it only runs on release tags.
Change History (13)
comment:1 Changed 18 months ago by
Branch: | → u/chapoton/32403 |
---|---|
Cc: | mkoeppe slelievre gh-DaveWitteMorris added |
Commit: | → 6e45e33a79860e7bc11aaf618adb20336b3f33a8 |
Status: | new → needs_review |
comment:2 Changed 18 months ago by
No, a major point of the "make dist" workflow is actually to check that the release manager has uploaded all files to the mirror!
comment:4 Changed 18 months ago by
Status: | needs_review → needs_work |
---|
It was designed to fail on branches that add/upgrade packages - until the release manager uploads the package tarball.
But I concede that this is at least poorly documented and does not serve us well any more in this form.
We can use your change (so that the failure goes away). I would add here on the same ticket a new workflow that only runs on release tags, not other branches or tags, to run the old "make dist" without --enable-download-from-upstream-url.
comment:5 Changed 18 months ago by
Branch: | u/chapoton/32403 → u/mkoeppe/32403 |
---|
comment:6 Changed 18 months ago by
Authors: | Frédéric Chapoton → Frédéric Chapoton, Matthias Koeppe |
---|---|
Commit: | 6e45e33a79860e7bc11aaf618adb20336b3f33a8 → 33e43d57c6e8118afe892fad0c1a4a32c536ad7a |
Status: | needs_work → needs_review |
The new workflow that is launched on release tags only has successfully run here: https://github.com/mkoeppe/sage/runs/3390524672?check_suite_focus=true
New commits:
33e43d5 | .github/workflows/sdist.yml: New
|
comment:7 Changed 18 months ago by
Description: | modified (diff) |
---|---|
Reviewers: | → Matthias Koeppe, ... |
Summary: | tweak tox.yml → tox.yml: Use --enable-download-from-upstream-url for make dist |
comment:10 Changed 18 months ago by
Cc: | gh-kliem dimpase added |
---|
comment:11 Changed 17 months ago by
Reviewers: | Matthias Koeppe, ... → Matthias Koeppe, Dima Pasechnik |
---|
lgtm
comment:12 Changed 17 months ago by
Status: | needs_review → positive_review |
---|
I will interpret that as a positive review
comment:13 Changed 17 months ago by
Branch: | u/mkoeppe/32403 → 33e43d57c6e8118afe892fad0c1a4a32c536ad7a |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
New commits:
tweak github tox.yml