Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#3239 closed defect (fixed)

[with patch; positive review] cygwin polybori -- add Cygwin build support for polybori

Reported by: was Owned by: mabshoff
Priority: major Milestone: sage-3.0.2
Component: porting: Cygwin Keywords:
Cc: PolyBoRi Merged in:
Authors: Reviewers:
Report Upstream: Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

See also #3195: add 64 bit OSX build support for polybori

New spkg here:

http://sage.math.washington.edu/home/was/cygwin/polybori-0.3.1.p3.spkg

Attachments (3)

cpu_stats.c.patch (389 bytes) - added by mabshoff 14 years ago.
Cygwin build fix
SConstruct.cygwin.patch (546 bytes) - added by mabshoff 14 years ago.
Cygwin python.exe fix
SConstruct.generic.patch (985 bytes) - added by PolyBoRi 14 years ago.
More generic patch, which obsoletes both patches above

Download all attachments as: .zip

Change History (8)

Changed 14 years ago by mabshoff

Cygwin build fix

Changed 14 years ago by mabshoff

Cygwin python.exe fix

comment:1 Changed 14 years ago by mabshoff

  • Cc PolyBoRi added
  • Summary changed from [with patch; needs review] cygwin polybori -- add Cygwin build support for polybori to [with patch; positive review] cygwin polybori -- add Cygwin build support for polybori

Spkg looks good to me. I checked in some diffs of all the patched files we use on Cygwin. I also attached those files to the ticket and added PolyBoRi? to the CC field on this ticket so the changes can get cleaned up and integrated upstream [at least the SConstuct fix must be cleaned up].

In total: Positive review.

Cheers,

Michael

comment:2 Changed 14 years ago by mabshoff

  • Resolution set to fixed
  • Status changed from new to closed

Merged in Sage 3.0.2.alpha1

comment:3 follow-up: Changed 14 years ago by PolyBoRi

Hi Michael, could you check, whether SConstruct.generic.patch does the Job on cygwin? Also, the first part of the cpu_stats.c.patch could be avoided by setting the predefines more sensitive in the construct file. I'll have a look at that issue in the next days. Best regards,

Alexander

comment:4 in reply to: ↑ 3 ; follow-up: Changed 14 years ago by mabshoff

Replying to PolyBoRi:

Hi Michael, could you check, whether SConstruct.generic.patch does the Job on cygwin? Also, the first part of the cpu_stats.c.patch could be avoided by setting the predefines more sensitive in the construct file. I'll have a look at that issue in the next days. Best regards,

Alexander

Hi Alexander,

that looks like a likely fix. Right now I don't have a Cygwin env setup up to test, but it won't take long.

Re cpu_stats.c: it looks like the sledge hammer approach and we conditionally copy it into the PolyBoRi? tree on Cygwin only. Any cleaner solution is appreciated and I plan to write some Win2K+ specific patches that uses the native Windows infrastructure for accounting and memory consumption. I already did so for CoCoALib, so it should be an easy fix.

Cheers,

Michael

Changed 14 years ago by PolyBoRi

More generic patch, which obsoletes both patches above

comment:5 in reply to: ↑ 4 Changed 14 years ago by PolyBoRi

Hi Michael,

that looks like a likely fix. Right now I don't have a Cygwin env setup up to test, but it won't take long.

Re cpu_stats.c: it looks like the sledge hammer approach and we conditionally copy it into the PolyBoRi? tree on Cygwin only. Any cleaner solution is appreciated and I plan to write some Win2K+ specific patches that uses the native Windows infrastructure for accounting and memory consumption. I already did so for CoCoALib, so it should be an easy fix.

I've uploaded an extended version of the patch, which should fix both problems from SConstruct, so the cpu_stats.c patch will be obsolete.

Best regards,

Alexander

Note: See TracTickets for help on using tickets.