Opened 18 months ago

Closed 16 months ago

#32373 closed enhancement (fixed)

sage_setup.library_order: Skip libraries that were not detected

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.5
Component: refactoring Keywords:
Cc: fbissey, gh-kliem, dimpase, arojas, mjo Merged in:
Authors: Matthias Koeppe Reviewers: Michael Orlitzky
Report Upstream: N/A Work issues:
Branch: 676111f (Commits, GitHub, GitLab) Commit: 676111f658dc3def03ad1b76437ec41feec0f729
Dependencies: Stopgaps:

Status badges

Description

This is a follow-up on #31384 and a neutral change for normal builds of sagelib. Needed for #29865 (Modularization of sagelib: Break out separate packages sagemath-objects, sagemath-categories)

Change History (11)

comment:1 Changed 18 months ago by mkoeppe

Branch: → u/mkoeppe/sage_setup_library_order__skip_libraries_that_were_not_detected

comment:2 Changed 18 months ago by mkoeppe

Authors: → Matthias Koeppe
Commit: → 4aff8a4f7110005867fb278ff94eb0c6de5069fb
Status: new → needs_review

New commits:

​4aff8a4sage_setup.library_order: Skip libraries that were not detected

comment:3 Changed 17 months ago by mkoeppe

Status: needs_review → needs_work

comment:4 Changed 17 months ago by git

Commit: 4aff8a4f7110005867fb278ff94eb0c6de5069fb → 676111f658dc3def03ad1b76437ec41feec0f729

Branch pushed to git repo; I updated commit sha1. New commits:

​676111fsage_setup.library_order: Take module list from new variables sage.env.default_{required,optional}_modules

comment:5 Changed 17 months ago by mkoeppe

Cc: gh-kliem added
Status: needs_work → needs_review

comment:6 Changed 17 months ago by mkoeppe

Cc: dimpase arojas added

comment:7 Changed 17 months ago by arojas

Works fine for distro build

comment:8 Changed 17 months ago by mkoeppe

Cc: mjo added

comment:9 Changed 16 months ago by mjo

Reviewers: → Michael Orlitzky
Status: needs_review → positive_review

Makes sense.

comment:10 Changed 16 months ago by mkoeppe

Thanks!

comment:11 Changed 16 months ago by vbraun

Branch: u/mkoeppe/sage_setup_library_order__skip_libraries_that_were_not_detected → 676111f658dc3def03ad1b76437ec41feec0f729
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.