Opened 12 months ago
Last modified 4 months ago
#32335 needs_work enhancement
VarchenkoGelfand ring of a hyperplane arrangement
Reported by:  tkarn  Owned by:  tkarn 

Priority:  major  Milestone:  sage9.7 
Component:  algebra  Keywords:  gsoc2021 hyperplane varchenkogelfand 
Cc:  tscrim, tkarn, ghgalendorp, saliola  Merged in:  
Authors:  Galen DorpalenBarry, Franco Saliola  Reviewers:  Trevor K. Karn, Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  public/algebras/varchenko_gelfand_algebra32335 (Commits, GitHub, GitLab)  Commit:  b60ca5dd06c5402c3dc5eb0efb9a0bc6e7167345 
Dependencies:  #32351  Stopgaps: 
Description
Implement the VarchenkoGelfand ring of a hyperplane arrangement.
Change History (17)
comment:1 Changed 12 months ago by
 Branch set to 32351
comment:2 Changed 12 months ago by
 Branch 32351 deleted
 Dependencies set to #32351
comment:3 Changed 12 months ago by
 Branch set to u/tkarn/varchenkogelfandring32335
 Commit set to d9044f2d114424a02e857e20d2ec3a586f141804
 Owner changed from (none) to tkarn
comment:4 Changed 12 months ago by
 Commit changed from d9044f2d114424a02e857e20d2ec3a586f141804 to 622ce83636cc7e8e516f77862931c7489783318b
comment:5 Changed 12 months ago by
 Commit changed from 622ce83636cc7e8e516f77862931c7489783318b to baa472bcbd7b95011540af35f029ed5804081a4f
Branch pushed to git repo; I updated commit sha1. New commits:
baa472b  Fix string formatting issues in doctests

comment:6 Changed 12 months ago by
 Commit changed from baa472bcbd7b95011540af35f029ed5804081a4f to 5d71a140d7dcd4077ac2cecb51a728209c11e747
Branch pushed to git repo; I updated commit sha1. New commits:
5d71a14  Fix doctests  all now pass

comment:7 Changed 12 months ago by
 Commit changed from 5d71a140d7dcd4077ac2cecb51a728209c11e747 to 78486499a77fbfdfb5fd006bd8b753a22fc56ba8
comment:8 Changed 12 months ago by
 Commit changed from 78486499a77fbfdfb5fd006bd8b753a22fc56ba8 to 52a4a61319787527a13edd2dc165af2f82ff1812
comment:9 Changed 12 months ago by
 Commit changed from 52a4a61319787527a13edd2dc165af2f82ff1812 to 725d306234812a96196e175eb56b0c3614efb322
comment:10 Changed 12 months ago by
 Commit changed from 725d306234812a96196e175eb56b0c3614efb322 to cb200cb30156001f0eba1df3caba47a817d6a2ae
Branch pushed to git repo; I updated commit sha1. New commits:
cb200cb  Remove rref of ideal, remove Moseley ring

comment:11 Changed 12 months ago by
 Status changed from new to needs_review
comment:12 Changed 12 months ago by
 Commit changed from cb200cb30156001f0eba1df3caba47a817d6a2ae to a021a0cf2e8acc9738de46b8b9b5449be484ab45
Branch pushed to git repo; I updated commit sha1. New commits:
a021a0c  Add missing period

comment:13 Changed 12 months ago by
 Branch changed from u/tkarn/varchenkogelfandring32335 to public/algebras/varchenko_gelfand_algebra32335
 Commit changed from a021a0cf2e8acc9738de46b8b9b5449be484ab45 to b60ca5dd06c5402c3dc5eb0efb9a0bc6e7167345
 Reviewers changed from Trevor K. Karn to Trevor K. Karn, Travis Scrimshaw
More changes will likely be needed, but here are some improvements and tweaks. I made it universally VG algebra to emphasize the choice of base ring here. I would only support calling it a ring if we are forcing it to have the same field as the hyperplane arrangement.
New commits:
18f8373  Merge branch 'u/tkarn/varchenkogelfandring32335' of git://trac.sagemath.org/sage into u/tkarn/varchenkogelfandring32335

b60ca5d  Some reviewer changes for VG algebras.

comment:14 Changed 12 months ago by
More changes will likely be needed, but here are some improvements and tweaks. I made it universally VG algebra to emphasize the choice of base ring here. I would only support calling it a ring if we are forcing it to have the same field as the hyperplane arrangement.
comment:15 Changed 12 months ago by
 Status changed from needs_review to needs_work
comment:16 Changed 8 months ago by
 Milestone changed from sage9.5 to sage9.6
comment:17 Changed 4 months ago by
 Milestone changed from sage9.6 to sage9.7
New commits:
Add hash to hyperplane arrangements
Initial commit
Adjust imports from local to sage
Add authors and copyright block
Remove self._base
Hide register_coercions
Remove extraneous comment