Opened 12 months ago

Last modified 4 months ago

#32335 needs_work enhancement

Varchenko-Gelfand ring of a hyperplane arrangement

Reported by: tkarn Owned by: tkarn
Priority: major Milestone: sage-9.7
Component: algebra Keywords: gsoc2021 hyperplane varchenko-gelfand
Cc: tscrim, tkarn, gh-galen-dorp, saliola Merged in:
Authors: Galen Dorpalen-Barry, Franco Saliola Reviewers: Trevor K. Karn, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: public/algebras/varchenko_gelfand_algebra-32335 (Commits, GitHub, GitLab) Commit: b60ca5dd06c5402c3dc5eb0efb9a0bc6e7167345
Dependencies: #32351 Stopgaps:

Status badges

Description

Implement the Varchenko-Gelfand ring of a hyperplane arrangement.

Change History (17)

comment:1 Changed 12 months ago by tkarn

  • Branch set to 32351

comment:2 Changed 12 months ago by tkarn

  • Branch 32351 deleted
  • Dependencies set to #32351

comment:3 Changed 12 months ago by tkarn

  • Branch set to u/tkarn/varchenko-gelfand-ring-32335
  • Commit set to d9044f2d114424a02e857e20d2ec3a586f141804
  • Owner changed from (none) to tkarn

New commits:

2186bd0Add hash to hyperplane arrangements
b3a209aInitial commit
dbdb6dcAdjust imports from local to sage
4c9e6a9Add authors and copyright block
9db6da9Remove self._base
e3edb79Hide register_coercions
d9044f2Remove extraneous comment

comment:4 Changed 12 months ago by git

  • Commit changed from d9044f2d114424a02e857e20d2ec3a586f141804 to 622ce83636cc7e8e516f77862931c7489783318b

Branch pushed to git repo; I updated commit sha1. New commits:

a1fb673Add base_ring method to fix category instantiation issue
82851c9Python 3 change iteritems -> items
622ce83Fix base_ring in MoseleyRing

comment:5 Changed 12 months ago by git

  • Commit changed from 622ce83636cc7e8e516f77862931c7489783318b to baa472bcbd7b95011540af35f029ed5804081a4f

Branch pushed to git repo; I updated commit sha1. New commits:

baa472bFix string formatting issues in doctests

comment:6 Changed 12 months ago by git

  • Commit changed from baa472bcbd7b95011540af35f029ed5804081a4f to 5d71a140d7dcd4077ac2cecb51a728209c11e747

Branch pushed to git repo; I updated commit sha1. New commits:

5d71a14Fix doctests - all now pass

comment:7 Changed 12 months ago by git

  • Commit changed from 5d71a140d7dcd4077ac2cecb51a728209c11e747 to 78486499a77fbfdfb5fd006bd8b753a22fc56ba8

Branch pushed to git repo; I updated commit sha1. New commits:

101f6d9Add VG to index.rst
7848649Update documentation

comment:8 Changed 12 months ago by git

  • Commit changed from 78486499a77fbfdfb5fd006bd8b753a22fc56ba8 to 52a4a61319787527a13edd2dc165af2f82ff1812

Branch pushed to git repo; I updated commit sha1. New commits:

32d0e4fMake nbc capitalization consistent
786378eAdd tests to _register_coercions and __init__
3f1c7a6Add tests to increase coverage and reformat warning
52a4a61Edit documentation

comment:9 Changed 12 months ago by git

  • Commit changed from 52a4a61319787527a13edd2dc165af2f82ff1812 to 725d306234812a96196e175eb56b0c3614efb322

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

60da428Edit documentation
725d306Add some examples and fix Hilbert series documentation

comment:10 Changed 12 months ago by git

  • Commit changed from 725d306234812a96196e175eb56b0c3614efb322 to cb200cb30156001f0eba1df3caba47a817d6a2ae

Branch pushed to git repo; I updated commit sha1. New commits:

cb200cbRemove rref of ideal, remove Moseley ring

comment:11 Changed 12 months ago by tkarn

  • Status changed from new to needs_review

comment:12 Changed 12 months ago by git

  • Commit changed from cb200cb30156001f0eba1df3caba47a817d6a2ae to a021a0cf2e8acc9738de46b8b9b5449be484ab45

Branch pushed to git repo; I updated commit sha1. New commits:

a021a0cAdd missing period

comment:13 Changed 12 months ago by tscrim

  • Branch changed from u/tkarn/varchenko-gelfand-ring-32335 to public/algebras/varchenko_gelfand_algebra-32335
  • Commit changed from a021a0cf2e8acc9738de46b8b9b5449be484ab45 to b60ca5dd06c5402c3dc5eb0efb9a0bc6e7167345
  • Reviewers changed from Trevor K. Karn to Trevor K. Karn, Travis Scrimshaw

More changes will likely be needed, but here are some improvements and tweaks. I made it universally VG algebra to emphasize the choice of base ring here. I would only support calling it a ring if we are forcing it to have the same field as the hyperplane arrangement.


New commits:

18f8373Merge branch 'u/tkarn/varchenko-gelfand-ring-32335' of git://trac.sagemath.org/sage into u/tkarn/varchenko-gelfand-ring-32335
b60ca5dSome reviewer changes for VG algebras.

comment:14 Changed 12 months ago by tscrim

More changes will likely be needed, but here are some improvements and tweaks. I made it universally VG algebra to emphasize the choice of base ring here. I would only support calling it a ring if we are forcing it to have the same field as the hyperplane arrangement.

comment:15 Changed 12 months ago by tkarn

  • Status changed from needs_review to needs_work

comment:16 Changed 8 months ago by mkoeppe

  • Milestone changed from sage-9.5 to sage-9.6

comment:17 Changed 4 months ago by mkoeppe

  • Milestone changed from sage-9.6 to sage-9.7
Note: See TracTickets for help on using tickets.