#32243 closed defect (fixed)

Patch gfan to use newer cddlib header location

Reported by: Michael Orlitzky Owned by:
Priority: major Milestone: sage-9.5
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Michael Orlitzky Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: db0dea5 (Commits, GitHub, GitLab) Commit: db0dea56c872e5b21c809e47aa35177f114470ca
Dependencies: Stopgaps:

Status badges

Description

In #29413 we're waiting mainly on gfan. There is no obvious way to submit things upstream, so we should just patch it finally. The spkg-configure.m4 for cddlib is looking for headers in the wrong location which, ironically, prevents the system gfan from being used.

Change History (8)

comment:1 Changed 17 months ago by Matthias Köppe

Let's import gfan to a GH repository then. (GH please, not GitLab, so we can include my portability testing script similar to https://github.com/mkoeppe/lrslib/tree/autoconfiscation/.github/workflows)

comment:2 Changed 17 months ago by Michael Orlitzky

We already insist on >=cddlib-094m which puts the headers in a cddlib/ subdirectory. All we should need to do for the gfan package at this point is sed 's/cdd/cddlib/g'. Afterwards we can have the spkg-configure.m4 for cddlib look in the right place (right now it's guaranteed to reject any vanilla system installations).

I'm build testing a patch already...

comment:3 Changed 17 months ago by Michael Orlitzky

Authors: Michael Orlitzky
Branch: u/mjo/ticket/32243
Commit: cfab03af1f3cd9be334da0ab07e3890bb183ece0
Status: newneeds_review

Anyone who cares will need to look at TOPCOM (#31531) because it will probably be broken with system cddlib, but that's not really my fault. Cddlib was upgraded already but the spkg-configure.m4 was left to reject system copies of it. Fixing that is now the right thing to do even if it breaks an optional package. (It looks like you were the last one to update it, in 2016...)

comment:4 in reply to:  3 Changed 17 months ago by Matthias Köppe

Milestone: sage-9.4sage-9.5

Replying to mjo:

Cddlib was upgraded already but the spkg-configure.m4 was left to reject system copies of it. Fixing that is now the right thing to do even if it breaks an optional package

... well, not for Sage 9.4 ...

comment:5 Changed 16 months ago by git

Commit: cfab03af1f3cd9be334da0ab07e3890bb183ece0db0dea56c872e5b21c809e47aa35177f114470ca

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

83f3545Trac #32243: patch gfan to look for cddlib headers in new location.
db0dea5Trac #32243: look for cddlib-0.94m headers in the right place.

comment:6 Changed 16 months ago by Dima Pasechnik

Reviewers: Dima Pasechnik

this seems to work.

comment:7 Changed 16 months ago by Dima Pasechnik

Status: needs_reviewpositive_review

comment:8 Changed 15 months ago by Volker Braun

Branch: u/mjo/ticket/32243db0dea56c872e5b21c809e47aa35177f114470ca
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.