Opened 17 months ago

Closed 17 months ago

#32175 closed enhancement (fixed)

Support FLINT 2.8.0

Reported by: Matthias Köppe Owned by:
Priority: critical Milestone: sage-9.4
Component: packages: standard Keywords:
Cc: Dima Pasechnik, François Bissey, Antonio Rojas Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: ff0c762 (Commits, GitHub, GitLab) Commit: ff0c762abb64bf847c9e5c07aa252640f5c01139
Dependencies: #31525 Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

flint-2.8.0-beta1 was released 2021-07-09 ​https://groups.google.com/g/sage-devel/c/EPoTzfCz3lg/m/aofwmlpWAAAJ

This ticket serves as the target ticket of the proposed portability testing workflow for FLINT (​https://github.com/wbhart/flint2/pull/972)

A patch to arb is required.

Test ticket with the FLINT upgrade: #32211

Change History (14)

comment:1 Changed 17 months ago by Matthias Köppe

Description: modified (diff)

comment:2 Changed 17 months ago by Matthias Köppe

Description: modified (diff)

comment:3 Changed 17 months ago by Matthias Köppe

With #32211 I am getting 

[arb-2.19.0] epsilon_arg.c:15:1: error: static declaration of 'fmpz_kronecker' follows non-static declaration
[arb-2.19.0] fmpz_kronecker(const fmpz_t a, const fmpz_t b)
[arb-2.19.0] ^
[arb-2.19.0] /Users/mkoeppe/s/sage/sage-rebasing/worktree-rebase/.tox/local-homebrew-macos-minimal/local/include/flint/fmpz.h:648:15: note: previous declaration is here
[arb-2.19.0] FLINT_DLL int fmpz_kronecker(const fmpz_t a, const fmpz_t n);
[arb-2.19.0]               ^
[arb-2.19.0] 1 error generated.
[arb-2.19.0] make[6]: *** [../build/acb_modular/epsilon_arg.lo] Error 1

comment:4 Changed 17 months ago by Matthias Köppe

Branch: → u/mkoeppe/support_flint_2_8_0

comment:5 Changed 17 months ago by Matthias Köppe

Authors: → Matthias Koeppe
Commit: → 2d4a8050554bf5238122e55ca549cf825cce659f
Description: modified (diff)
Priority: major → critical

New commits:

​2d4a805build/pkgs/arb/patches: Add https://github.com/fredrik-johansson/arb/commit/b6c8032e2da1b19eb7c5a5f5c2f3372643e3d170

comment:6 Changed 17 months ago by Matthias Köppe

Status: new → needs_review

Tests with FLINT 2.8.0-rc2 on #31525 show no errors (with the arb patch included). So it looks like with this ticket here we will be ready for systems shipping FLINT 2.8.x.

The actual upgrade in #31525 will need more work and can be delayed to Sage 9.5.

comment:7 Changed 17 months ago by Matthias Köppe

Cc: François Bissey Antonio Rojas added

comment:8 Changed 17 months ago by Dima Pasechnik

Reviewers: → Dima Pasechnik
Status: needs_review → positive_review

lgtm

comment:9 Changed 17 months ago by François Bissey

Status: positive_review → needs_work

Normally adding a patch requires a revision bump.

comment:10 Changed 17 months ago by git

Commit: 2d4a8050554bf5238122e55ca549cf825cce659f → d8c9f4fc3d724018336ddad657b23964208c3587

Branch pushed to git repo; I updated commit sha1. New commits:

​d8c9f4fbuild/pkgs/arb/package-version.txt: Bump patch level

comment:11 Changed 17 months ago by git

Commit: d8c9f4fc3d724018336ddad657b23964208c3587 → ff0c762abb64bf847c9e5c07aa252640f5c01139

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​ff0c762build/pkgs/arb/package-version.txt: Bump patch level

comment:12 Changed 17 months ago by Matthias Köppe

Status: needs_work → needs_review

comment:13 Changed 17 months ago by François Bissey

Status: needs_review → positive_review

Good.

comment:14 Changed 17 months ago by Volker Braun

Branch: u/mkoeppe/support_flint_2_8_0 → ff0c762abb64bf847c9e5c07aa252640f5c01139
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.