Opened 12 months ago

Closed 12 months ago

#32150 closed enhancement (fixed)

Set up prism with both Vrep and Hrep

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.4
Component: geometry Keywords: polyhedron, double description, precomputed, prism
Cc: Merged in:
Authors: Jonathan Kliem Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: f75726d (Commits, GitHub, GitLab) Commit: f75726d37348b2eb745124934a054e1f2addba80
Dependencies: Stopgaps:

Status badges

Description

We set up the prism over a polyhedron with the double description.

Before: 

sage: P = polytopes.permutahedron(6)                                                                                                                                                
sage: %time Q = P.prism()                                                                                                                                                           
CPU times: user 231 ms, sys: 7.92 ms, total: 239 ms
Wall time: 237 ms
sage: P = polytopes.hypercube(8)                                                                                                                                                    
sage: %time Q = P.prism()                                                                                                                                                           
CPU times: user 65.3 ms, sys: 28 µs, total: 65.3 ms
Wall time: 63.9 ms
sage: P = polytopes.cross_polytope(8)                                                                                                                                               
sage: %time Q = P.prism()                                                                                                                                                           
CPU times: user 39.4 ms, sys: 0 ns, total: 39.4 ms
Wall time: 38.6 ms
sage: P = polytopes.hypercube(6, backend='field')                                                                                                                                   
sage: %time Q = P.prism()                                                                                                                                                           
CPU times: user 3.47 s, sys: 3.97 ms, total: 3.48 s
Wall time: 3.48 s

After: 

sage: P = polytopes.permutahedron(6)                                                                                                                                                                                                                                           
sage: %time Q = P.prism()                                                                                                                                                                                                                                                      
CPU times: user 56.7 ms, sys: 3.85 ms, total: 60.6 ms
Wall time: 59.8 ms
sage: P = polytopes.hypercube(8)                                                                                                                                                                                                                                               
sage: %time Q = P.prism()                                                                                                                                                                                                                                                      
CPU times: user 26.5 ms, sys: 0 ns, total: 26.5 ms
Wall time: 26.2 ms
sage: P = polytopes.cross_polytope(8)                                                                                                                                                                                                                                          
sage: %time Q = P.prism()                                                                                                                                                                                                                                                      
CPU times: user 33.7 ms, sys: 0 ns, total: 33.7 ms
Wall time: 33 ms
sage: P = polytopes.hypercube(6, backend='field')                                                                                                                                                                                                                              
sage: %time Q = P.prism()                                                                                                                                                                                                                                                      
CPU times: user 14.1 ms, sys: 0 ns, total: 14.1 ms
Wall time: 13.8 ms
sage: P = polytopes.hypercube(10, backend='field')                                                                                                                                                                                                                             
sage: %time Q = P.prism()                                                                                                                                                                                                                                                      
CPU times: user 32.3 ms, sys: 0 ns, total: 32.3 ms
Wall time: 31.8 ms

Change History (5)

comment:1 Changed 12 months ago by gh-kliem

  • Status changed from new to needs_review

comment:2 Changed 12 months ago by git

  • Commit changed from 41a6951ffb36b55ba20dc365a0e8789fc6bf9736 to f75726d37348b2eb745124934a054e1f2addba80

Branch pushed to git repo; I updated commit sha1. New commits:

​0cfc146tiny improvements
​f75726donly compute prism once

comment:3 Changed 12 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 12 months ago by gh-kliem

Thank you.

comment:5 Changed 12 months ago by vbraun

  • Branch changed from u/gh-kliem/double_description_prism to f75726d37348b2eb745124934a054e1f2addba80
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.