Opened 13 months ago
Closed 13 months ago
#32145 closed enhancement (fixed)
Finite dimensional twisted invariant module
Reported by:  tkarn  Owned by:  

Priority:  major  Milestone:  sage9.4 
Component:  algebra  Keywords:  gsoc2021 invariant twisted isotypic representation 
Cc:  tscrim, tkarn  Merged in:  
Authors:  Trevor K. Karn  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  aca3187 (Commits, GitHub, GitLab)  Commit:  aca3187e943fdd057da737385c6758af1a95c7f7 
Dependencies:  #31939 #32190  Stopgaps: 
Description
The twisted (or skew) invariant module is the isotypic component of a (finitedimensional) reprensentation corresponding to an irreducible representation of a finite group. This ticket aims to implement the twisted invariant in sage.modules.with_basis.invariant
Change History (11)
comment:1 Changed 13 months ago by
comment:2 Changed 13 months ago by
 Dependencies changed from #31939 to #31939 #32190
comment:3 Changed 13 months ago by
 Branch set to u/tkarn/twisted_invariant32145
 Commit set to dbde994dbf079ad43e843192601d7a3d7b0d0e01
Last 10 new commits:
fb66962  Add check for valid characters for finite semigroups

a3079a4  Add basis computation and initial commit of Element class

55c7e6a  Initial commit of rewritten twisted invariant

5b8e732  Fix whitespace

01d1cf2  Fix more whitespace issues

4541a9f  Add __hash__ to ClassFunction_gap

0600e1d  First functional twisted invariant

f9f2061  Remove extraneous comments

384464b  Add examples

dbde994  Fix tests

comment:4 Changed 13 months ago by
 Commit changed from dbde994dbf079ad43e843192601d7a3d7b0d0e01 to d71cf293eed61c5af1ba7f7f43f3bcdbe2720b88
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
11e33d3  Add basis computation and initial commit of Element class

a338087  Initial commit of rewritten twisted invariant

99a2597  Fix whitespace

06f98d5  Fix more whitespace issues

2ddfb3b  Add __hash__ to ClassFunction_gap

4817bdf  First functional twisted invariant

57f0030  Remove extraneous comments

e2c7069  Add examples

a02b134  Fix tests

d71cf29  Refactor to remove dict option for chi and fix to make initial tests pass

comment:5 Changed 13 months ago by
 Commit changed from d71cf293eed61c5af1ba7f7f43f3bcdbe2720b88 to ae6c9371c485720043356ef8ca211d7504a60f0d
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
6d0a7fd  Fix whitespace

e248849  Fix more whitespace issues

10d66f2  Add __hash__ to ClassFunction_gap

7185f88  First functional twisted invariant

f743638  Remove extraneous comments

338688f  Add examples

2565968  Fix tests

2fc7373  Refactor to remove dict option for chi and fix to make initial tests pass

dbaf96d  Add examples

ae6c937  Fix broken example, fix bug in .annihilator_basis call, add alias TwistedInvariantModule, remove lambda's

comment:6 Changed 13 months ago by
 Commit changed from ae6c9371c485720043356ef8ca211d7504a60f0d to 0115c9c3ea39c83740a832991a1341c3ce15915b
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
9c25b45  Fix broken example, fix bug in .annihilator_basis call, add alias TwistedInvariantModule, remove lambda's

b79c3ad  Clean up tests

31a7b52  Add __main__.action to test

71573e1  Fix PEP8 issues

20d764f  Fix issues with parents and change to morphism

0965ffa  Add twisted_invariant_module method to FiniteDimensionalModulesWithBasis.Parent

1e85084  Move import of Represntation because it is used so much

0a34cba  Add tests/documentation

d3c17df  Add twisted_invariant_module method to Representation_abstract

0115c9c  Add some tests using coinvariant

comment:7 Changed 13 months ago by
 Commit changed from 0115c9c3ea39c83740a832991a1341c3ce15915b to b8c24bc73139be102b9ca9435e4c410d0ba09e76
comment:8 Changed 13 months ago by
 Status changed from new to needs_review
comment:9 Changed 13 months ago by
 Branch changed from u/tkarn/twisted_invariant32145 to u/tscrim/twisted_invariant32145
 Commit changed from b8c24bc73139be102b9ca9435e4c410d0ba09e76 to aca3187e943fdd057da737385c6758af1a95c7f7
 Reviewers set to Travis Scrimshaw
Here is with my reviewer changes. Note that I rebased this on the two dependencies and squashed the commits. So do not simply merge it and instead pull the branch fresh. If my changes are good, then positive review.
Last 10 new commits:
42d5e34  Fix _mul_ to assume that both are in same parent

c038ef5  Edit exposition in symmetric function example

a75293a  Add exposition in examples

553dc56  Reviewer changes for invariant modules.

2a64c19  Update input documentation

0799238  Merge branch 'public/algebras/invariant_modules31939' of git://trac.sagemath.org/sage into u/tscrim/twisted_invariant32145

cdd59ab  Remove .values()

38e1702  Merge branch 'u/tkarn/class_function_hash32190' of git://trac.sagemath.org/sage into u/tscrim/twisted_invariant32145

c507bc0  Implement the twisted invariant module.

aca3187  Reviewer changes for twisted invariant modules.

comment:11 Changed 13 months ago by
 Branch changed from u/tscrim/twisted_invariant32145 to aca3187e943fdd057da737385c6758af1a95c7f7
 Resolution set to fixed
 Status changed from positive_review to closed
This is splitting the original ticket #31939 into two parts, one for the usual invariant (#31939 itself) and this one for the twisted invariant.