#32117 closed defect (fixed)

Random relative number field checks only irreducibility over QQ

Reported by: gh-kliem Owned by:
Priority: major Milestone: sage-9.4
Component: algebra Keywords:
Cc: Merged in:
Authors: Jonathan Kliem Reviewers: Markus Wageringel
Report Upstream: N/A Work issues:
Branch: cd056b2 (Commits, GitHub, GitLab) Commit: cd056b2023da6a3d240979631abb1482fd106b29
Dependencies: Stopgaps:

Status badges

Description

sage: set_random_seed(3030)                                                                                                           
sage: from sage.rings.tests import relative_number_field                                                                              
sage: relative_number_field(3)    
...
ValueError: defining polynomial (x^2 - 15*x - 45) must be irreducible

Change History (4)

comment:1 Changed 12 months ago by gh-kliem

  • Branch set to public/32117
  • Commit set to cd056b2023da6a3d240979631abb1482fd106b29
  • Status changed from new to needs_review

New commits:

cd056b2check reducibility of polynomial with correct base ring

comment:2 Changed 12 months ago by gh-mwageringel

  • Reviewers set to Markus Wageringel
  • Status changed from needs_review to positive_review

The fix looks correct to me and seems to work.

comment:3 Changed 12 months ago by gh-kliem

Thank you.

comment:4 Changed 11 months ago by vbraun

  • Branch changed from public/32117 to cd056b2023da6a3d240979631abb1482fd106b29
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.