Opened 11 months ago
Closed 10 months ago
#32116 closed enhancement (fixed)
Chart._parse_coordinates
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sage9.4 
Component:  manifolds  Keywords:  
Cc:  egourgoulhon, vbraun  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Eric Gourgoulhon 
Report Upstream:  N/A  Work issues:  
Branch:  u/mkoeppe/chart__parse_coordinates (Commits, GitHub, GitLab)  Commit:  3d1c44d7e5dde0c2a65740a615998205b48be075 
Dependencies:  #32009  Stopgaps: 
Change History (13)
comment:1 Changed 11 months ago by
 Dependencies set to #32009
comment:2 Changed 11 months ago by
 Branch set to u/mkoeppe/chart__parse_coordinates
comment:3 Changed 11 months ago by
 Commit set to 4db499543d24006d4ea3b87c956baa5f0bee03a7
 Status changed from new to needs_review
comment:4 Changed 11 months ago by
 Commit changed from 4db499543d24006d4ea3b87c956baa5f0bee03a7 to fc59c9d6d46faeefd12626ab9946631de2608424
Branch pushed to git repo; I updated commit sha1. New commits:
fc59c9d  Chart.__classcall__: Add doctest

comment:5 Changed 11 months ago by
 Commit changed from fc59c9d6d46faeefd12626ab9946631de2608424 to 1742fdccd1e491fa6c15b18acf9990178a8495c0
comment:6 Changed 11 months ago by
In line 413 of chart.py
, the doctest
sage: Chart._parse_coordinates(M, ['z1:\zeta_1', r'z2:\zeta_2'])
fails due to a missing raw string marker.
comment:7 Changed 11 months ago by
Apart from comment:6, this looks nice!
comment:8 Changed 11 months ago by
 Commit changed from 1742fdccd1e491fa6c15b18acf9990178a8495c0 to 9ac183438b80e55d6d994d61f5d92a7c5e056026
Branch pushed to git repo; I updated commit sha1. New commits:
9ac1834  src/sage/manifolds/chart.py: Add raw string marker

comment:9 Changed 11 months ago by
 Reviewers set to Eric Gourgoulhon
 Status changed from needs_review to positive_review
Thanks!
comment:10 Changed 11 months ago by
Thank you!
comment:11 Changed 10 months ago by
 Commit changed from 9ac183438b80e55d6d994d61f5d92a7c5e056026 to 3d1c44d7e5dde0c2a65740a615998205b48be075
 Status changed from positive_review to needs_review
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. Last 10 new commits:
69d045a  ConditionSet: In doctests, do not rename ZZ^2 etc.

daeb91e  src/sage/sets/set.py: Fix docstring markup

2cf2199  Merge #32015

1eb270a  src/sage/docs/conf.py: Add more \ensuremath to \DeclareUnicodeCharacter

2682469  src/sage/interfaces/sympy_wrapper.py: Use Family, not Set, in doctests to make sure that the SageSet wrapper is actually used

753babb  Set_object_enumerated._sympy_: Translate empty sets to EmptySet

141ecde  Merge #32015

bf62543  Merge branch 't/32089/conditionset__conditionset_callable_symbolic_expression' into t/32009/eliminate_direct_use_of_the_chart__domain_attribute

ea08261  Merge #32009

3d1c44d  Merge tag '9.4.beta5' into t/32116/chart__parse_coordinates

comment:12 Changed 10 months ago by
 Status changed from needs_review to positive_review
comment:13 Changed 10 months ago by
 Cc vbraun added
 Resolution set to fixed
 Status changed from positive_review to closed
Apparently this has been merged as part of #32089.
Note: See
TracTickets for help on using
tickets.
New commits:
Eliminate direct use of Chart._domain
Merge #32009
Chart: Replace _init_coordinates by _parse_coordinates
Chart: Fix up __classcall__ and _parse_coordinates by avoiding unhashable things