Opened 15 months ago
Last modified 7 days ago
#32035 needs_review enhancement
Multiplier Spectra for P^N, N > 1
Reported by:  Alexander Galarraga  Owned by:  

Priority:  minor  Milestone:  sage9.8 
Component:  dynamics  Keywords:  gsoc2021 
Cc:  Ben Hutz  Merged in:  
Authors:  Alexander Galarraga  Reviewers:  Ben Hutz 
Report Upstream:  N/A  Work issues:  
Branch:  u/ghEnderWannabe/multiplier_spectra (Commits, GitHub, GitLab)  Commit:  4a0e9a1d49ffa4879a3e9b159e685d59dd93a2e1 
Dependencies:  #31944, #32041  Stopgaps: 
Description (last modified by )
Currently the multiplier spectra function for dynamical systems on P^{N} throws a NotImplementedError? when N > 1.
This ticket aims to implement that functionality.
Change History (25)
comment:1 Changed 15 months ago by
Description:  modified (diff) 

comment:2 Changed 15 months ago by
Branch:  → u/ghEnderWannabe/multiplier_spectra 

comment:3 Changed 15 months ago by
Commit:  → d23769a9663ec111b63dc014b7957977b5097db6 

Dependencies:  31944 → #31944 
comment:4 Changed 15 months ago by
Dependencies:  #31944 → #31944, #32041 

comment:5 Changed 15 months ago by
Commit:  d23769a9663ec111b63dc014b7957977b5097db6 → dbbd3dc4e63ce1dc22665359b19acf4ab844e55e 

comment:6 Changed 15 months ago by
Status:  new → needs_review 

comment:7 Changed 15 months ago by
Commit:  dbbd3dc4e63ce1dc22665359b19acf4ab844e55e → 2f064fd15867ac92d5775f3af39d740a4a8ee07a 

comment:8 Changed 15 months ago by
Commit:  2f064fd15867ac92d5775f3af39d740a4a8ee07a → 732b08aa8cc4c2bd93b2125fe9d1f8b2e19f4437 

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
b4ec7c1  31944: minor fixes

6b810a2  31944: fixed periodic typo and added test

b8ce4b7  31906: actual fix for warning message

dc36d19  Merge branch 'u/ghEnderWannabe/point_matrix_improvement' of trac.sagemath.org:sage into point_transformation_improvement

e7e8930  31906: fixed denominator bug

e49e34c  Merge branch 'point_transformation_improvement' into periodic_points_improvement

3a04a8d  31944: fixed bug with formal=True over ring

4a62742  Merge branch 'develop' into periodic_points_improvement

e3693f0  31944: added error message for fraction fields of m polynomial rings

732b08a  Merge branch 'periodic_points_improvement' into multiplier_spectra

comment:9 Changed 15 months ago by
Commit:  732b08aa8cc4c2bd93b2125fe9d1f8b2e19f4437 → 27de53e73e4b1958ebedbebea4b135b43b7ab895 

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
b82de34  Merge branch 'u/ghEnderWannabe/hyperplane_transform' of trac.sagemath.org:sage into hyperplane_transform

379a732  Merge branch 'hyperplane_transform' into affine_preperiodic

15f206c  32166: fixed typos, added subscheme example

b4246d2  32166: fixed identity matrix return

eaebd33  32166: added test for identity

57a4b39  Merge branch 'affine_preperiodic' into periodic_points_improvement

81d7c97  32166: fixed documentation

a63927e  Merge branch 'affine_preperiodic' into periodic_points_improvement

9b5e74f  31944: fixed calls to affine preperiodic model

27de53e  Merge branch 'periodic_points_improvement' into multiplier_spectra

comment:10 Changed 15 months ago by
Reviewers:  → Ben Hutz 

Status:  needs_review → needs_work 
I see no issues with functionality. A few minor doc things and one extra if
.
 the default is formal=False, so the first main paragraph should not say it computes the formal unless the user specifies otherwise (i.e., that logic should be reversed)
 end of second paragraph  "critical points" should be "periodic points"
 If False, and he map is > "the"
 use_algebraic_closure  "critical points" should be "periodic points"
 no examples of algebraic closures in dimension > 1
 line 4711  need line wrap
 line 4798  extra word in comment ("which *point* the point")
 line 4817  aren't we already in the dimension == 1 case?
 looks like this needs to be updated for the latest preperiodic point ticket (31944)
comment:11 Changed 15 months ago by
Commit:  27de53e73e4b1958ebedbebea4b135b43b7ab895 → 2ab4ac647430e2d4b0d0d71a5f360a7b823268dd 

Branch pushed to git repo; I updated commit sha1. New commits:
b695b25  Merge branch 'u/ghEnderWannabe/multiplier_spectra' of git://trac.sagemath.org/sage into multiplier_spectra

f1e1958  31944: fix for subscheme issue

d3ea2be  31944: added check for morphisms

268bc83  31944: fixed if statement

6f2857f  31944: added example for formal preperiodic

8827e74  Merge branch 'u/ghEnderWannabe/periodic_points_improvement' of git://trac.sagemath.org/sage into periodic_points_improvement

c35b14a  Merge branch 'periodic_points_improvement' into multiplier_spectra

2ab4ac6  32035: doc fixes

comment:12 Changed 15 months ago by
Status:  needs_work → needs_review 

comment:13 Changed 14 months ago by
Branch:  u/ghEnderWannabe/multiplier_spectra → u/bhutz/multiplier_spectra 

comment:14 followup: 16 Changed 14 months ago by
Commit:  2ab4ac647430e2d4b0d0d71a5f360a7b823268dd → 25b19e23bff5e69d0f282b7810e1b42c5e29450d 

Status:  needs_review → needs_work 
The commit fixed a couple of the missed doc issues, but the use_algebraic_closure example is still an issue and exposes an problem. If you only use the base_field when it is false you are missing periodic points and hence not returning the full multiplier spectrum.
One option is to count the number of points you have (with multiplicity) and throw an error if the base field doesn't contain them all.
New commits:
25b19e2  32035: minor doc fixes

comment:15 Changed 14 months ago by
Branch:  u/bhutz/multiplier_spectra → u/ghEnderWannabe/multiplier_spectra 

comment:16 Changed 14 months ago by
Commit:  25b19e23bff5e69d0f282b7810e1b42c5e29450d → 5fcf96d531c13d011d23143dd594240ed6e70f0b 

comment:17 Changed 14 months ago by
Status:  needs_work → needs_review 

comment:18 Changed 14 months ago by
Status:  needs_review → positive_review 

comment:20 Changed 14 months ago by
Milestone:  sage9.4 → sage9.5 

comment:21 Changed 10 months ago by
Milestone:  sage9.5 → sage9.6 

comment:22 Changed 6 months ago by
Milestone:  sage9.6 → sage9.7 

comment:23 Changed 10 days ago by
Milestone:  sage9.7 → sage9.8 

comment:24 Changed 7 days ago by
Commit:  5fcf96d531c13d011d23143dd594240ed6e70f0b → 4a0e9a1d49ffa4879a3e9b159e685d59dd93a2e1 

Branch pushed to git repo; I updated commit sha1. New commits:
4a0e9a1  Merge branch 'u/ghEnderWannabe/multiplier_spectra' of trac.sagemath.org:sage into 32035

comment:25 Changed 7 days ago by
Status:  needs_work → needs_review 

Last 10 new commits:
31954: initial commit with working code and examples
Merge branch 'hyperplane_transform' into periodic_points_improvement
31944: added computation for formal periodic points
31944: removed changes in tickets 31906 and 31896 from this ticket
31944: initial formal preperiodic points
31944: examples for formal preperiodic points, fixed return scheme for formal preperiodic points
Merge branch 'u/ghEnderWannabe/periodic_points_improvement' of trac.sagemath.org:sage into multiplier_spectra
working on number fields
Merge branch 'develop' into multiplier_spectra
32035: added tests, functionality for QQbar and algebraic closures of finite fields