Opened 15 months ago

Last modified 7 days ago

#32035 needs_review enhancement

Multiplier Spectra for P^N, N > 1

Reported by: Alexander Galarraga Owned by:
Priority: minor Milestone: sage-9.8
Component: dynamics Keywords: gsoc2021
Cc: Ben Hutz Merged in:
Authors: Alexander Galarraga Reviewers: Ben Hutz
Report Upstream: N/A Work issues:
Branch: u/gh-EnderWannabe/multiplier_spectra (Commits, GitHub, GitLab) Commit: 4a0e9a1d49ffa4879a3e9b159e685d59dd93a2e1
Dependencies: #31944, #32041 Stopgaps:

Status badges

Description (last modified by Alexander Galarraga)

Currently the multiplier spectra function for dynamical systems on PN throws a NotImplementedError? when N > 1.

This ticket aims to implement that functionality.

Change History (25)

comment:1 Changed 15 months ago by Alexander Galarraga

Description: modified (diff)

comment:2 Changed 15 months ago by Alexander Galarraga

Branch: u/gh-EnderWannabe/multiplier_spectra

comment:3 Changed 15 months ago by Alexander Galarraga

Commit: d23769a9663ec111b63dc014b7957977b5097db6
Dependencies: 31944#31944

Last 10 new commits:

27888da31954: initial commit with working code and examples
22201d7Merge branch 'hyperplane_transform' into periodic_points_improvement
c32484431944: added computation for formal periodic points
91ebb2231944: removed changes in tickets 31906 and 31896 from this ticket
df038ca31944: initial formal preperiodic points
5d142bf31944: examples for formal preperiodic points, fixed return scheme for formal preperiodic points
d4957f4Merge branch 'u/gh-EnderWannabe/periodic_points_improvement' of trac.sagemath.org:sage into multiplier_spectra
254b1a8working on number fields
ab0b37cMerge branch 'develop' into multiplier_spectra
d23769a32035: added tests, functionality for QQbar and algebraic closures of finite fields

comment:4 Changed 15 months ago by Alexander Galarraga

Dependencies: #31944#31944, #32041

comment:5 Changed 15 months ago by git

Commit: d23769a9663ec111b63dc014b7957977b5097db6dbbd3dc4e63ce1dc22665359b19acf4ab844e55e

Branch pushed to git repo; I updated commit sha1. New commits:

9a2c01c32041: added fix and test
0903a77Merge branch 'reduced_form_fix' into multiplier_spectra
558c25532035: cleaned up code, added documentation
dbbd3dc32035: added test for algebraic closure

comment:6 Changed 15 months ago by Alexander Galarraga

Status: newneeds_review

comment:7 Changed 15 months ago by git

Commit: dbbd3dc4e63ce1dc22665359b19acf4ab844e55e2f064fd15867ac92d5775f3af39d740a4a8ee07a

Branch pushed to git repo; I updated commit sha1. New commits:

083b6fa32035: minor code cleanup
2f064fd32035: added comments, fixed output documentation

comment:8 Changed 15 months ago by git

Commit: 2f064fd15867ac92d5775f3af39d740a4a8ee07a732b08aa8cc4c2bd93b2125fe9d1f8b2e19f4437

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

b4ec7c131944: minor fixes
6b810a231944: fixed periodic typo and added test
b8ce4b731906: actual fix for warning message
dc36d19Merge branch 'u/gh-EnderWannabe/point_matrix_improvement' of trac.sagemath.org:sage into point_transformation_improvement
e7e893031906: fixed denominator bug
e49e34cMerge branch 'point_transformation_improvement' into periodic_points_improvement
3a04a8d31944: fixed bug with formal=True over ring
4a62742Merge branch 'develop' into periodic_points_improvement
e3693f031944: added error message for fraction fields of m polynomial rings
732b08aMerge branch 'periodic_points_improvement' into multiplier_spectra

comment:9 Changed 15 months ago by git

Commit: 732b08aa8cc4c2bd93b2125fe9d1f8b2e19f443727de53e73e4b1958ebedbebea4b135b43b7ab895

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

b82de34Merge branch 'u/gh-EnderWannabe/hyperplane_transform' of trac.sagemath.org:sage into hyperplane_transform
379a732Merge branch 'hyperplane_transform' into affine_preperiodic
15f206c32166: fixed typos, added subscheme example
b4246d232166: fixed identity matrix return
eaebd3332166: added test for identity
57a4b39Merge branch 'affine_preperiodic' into periodic_points_improvement
81d7c9732166: fixed documentation
a63927eMerge branch 'affine_preperiodic' into periodic_points_improvement
9b5e74f31944: fixed calls to affine preperiodic model
27de53eMerge branch 'periodic_points_improvement' into multiplier_spectra

comment:10 Changed 15 months ago by Ben Hutz

Reviewers: Ben Hutz
Status: needs_reviewneeds_work

I see no issues with functionality. A few minor doc things and one extra if.

  • the default is formal=False, so the first main paragraph should not say it computes the formal unless the user specifies otherwise (i.e., that logic should be reversed)
  • end of second paragraph - "critical points" should be "periodic points"
  • If False, and he map is -> "the"
  • use_algebraic_closure - "critical points" should be "periodic points"
  • no examples of algebraic closures in dimension > 1
  • line 4711 -- need line wrap
  • line 4798 -- extra word in comment ("which *point* the point")
  • line 4817 -- aren't we already in the dimension == 1 case?
  • looks like this needs to be updated for the latest preperiodic point ticket (31944)

comment:11 Changed 15 months ago by git

Commit: 27de53e73e4b1958ebedbebea4b135b43b7ab8952ab4ac647430e2d4b0d0d71a5f360a7b823268dd

Branch pushed to git repo; I updated commit sha1. New commits:

b695b25Merge branch 'u/gh-EnderWannabe/multiplier_spectra' of git://trac.sagemath.org/sage into multiplier_spectra
f1e195831944: fix for subscheme issue
d3ea2be31944: added check for morphisms
268bc8331944: fixed if statement
6f2857f31944: added example for formal preperiodic
8827e74Merge branch 'u/gh-EnderWannabe/periodic_points_improvement' of git://trac.sagemath.org/sage into periodic_points_improvement
c35b14aMerge branch 'periodic_points_improvement' into multiplier_spectra
2ab4ac632035: doc fixes

comment:12 Changed 15 months ago by Alexander Galarraga

Status: needs_workneeds_review

comment:13 Changed 14 months ago by Ben Hutz

Branch: u/gh-EnderWannabe/multiplier_spectrau/bhutz/multiplier_spectra

comment:14 Changed 14 months ago by Ben Hutz

Commit: 2ab4ac647430e2d4b0d0d71a5f360a7b823268dd25b19e23bff5e69d0f282b7810e1b42c5e29450d
Status: needs_reviewneeds_work

The commit fixed a couple of the missed doc issues, but the use_algebraic_closure example is still an issue and exposes an problem. If you only use the base_field when it is false you are missing periodic points and hence not returning the full multiplier spectrum.

One option is to count the number of points you have (with multiplicity) and throw an error if the base field doesn't contain them all.


New commits:

25b19e232035: minor doc fixes

comment:15 Changed 14 months ago by Alexander Galarraga

Branch: u/bhutz/multiplier_spectrau/gh-EnderWannabe/multiplier_spectra

comment:16 in reply to:  14 Changed 14 months ago by Alexander Galarraga

Commit: 25b19e23bff5e69d0f282b7810e1b42c5e29450d5fcf96d531c13d011d23143dd594240ed6e70f0b

Replying to bhutz:

One option is to count the number of points you have (with multiplicity) and throw an error if the base field doesn't contain them all.

Good catch. Added such a check.


New commits:

5fcf96d32035: added check for if the full spectra was computed

comment:17 Changed 14 months ago by Alexander Galarraga

Status: needs_workneeds_review

comment:18 Changed 14 months ago by Ben Hutz

Status: needs_reviewpositive_review

comment:19 Changed 14 months ago by Volker Braun

Status: positive_reviewneeds_work

Merge conflict

comment:20 Changed 14 months ago by Matthias Köppe

Milestone: sage-9.4sage-9.5

comment:21 Changed 10 months ago by Matthias Köppe

Milestone: sage-9.5sage-9.6

comment:22 Changed 6 months ago by Matthias Köppe

Milestone: sage-9.6sage-9.7

comment:23 Changed 10 days ago by Matthias Köppe

Milestone: sage-9.7sage-9.8

comment:24 Changed 7 days ago by git

Commit: 5fcf96d531c13d011d23143dd594240ed6e70f0b4a0e9a1d49ffa4879a3e9b159e685d59dd93a2e1

Branch pushed to git repo; I updated commit sha1. New commits:

4a0e9a1Merge branch 'u/gh-EnderWannabe/multiplier_spectra' of trac.sagemath.org:sage into 32035

comment:25 Changed 7 days ago by Alexander Galarraga

Status: needs_workneeds_review
Note: See TracTickets for help on using tickets.