#32011 closed enhancement (fixed)

various fixes about relint warnings

Reported by: chapoton Owned by:
Priority: major Milestone: sage-9.4
Component: refactoring Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 192cc5c (Commits, GitHub, GitLab) Commit: 192cc5c06d393fd2a6980cd756e628c2c2571848
Dependencies: Stopgaps:

Status badges

Description

also removing some # py2 tags

Change History (6)

comment:1 Changed 14 months ago by chapoton

  • Branch set to u/chapoton/32011
  • Commit set to a4f50a9380de290826a2f90bc9402b24531e4eb7
  • Status changed from new to needs_review

New commits:

ac872c6typo
a4f50a9various little fixes, including removing some py2 tags

comment:2 Changed 14 months ago by mkoeppe

  • Reviewers set to Matthias Koeppe
  • Status changed from needs_review to positive_review

comment:3 Changed 14 months ago by git

  • Commit changed from a4f50a9380de290826a2f90bc9402b24531e4eb7 to 192cc5c06d393fd2a6980cd756e628c2c2571848
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

192cc5csome further details

comment:4 Changed 14 months ago by chapoton

sorry, but one doctest was failing..

comment:5 Changed 14 months ago by mkoeppe

  • Status changed from needs_review to positive_review

green patchbot

comment:6 Changed 14 months ago by vbraun

  • Branch changed from u/chapoton/32011 to 192cc5c06d393fd2a6980cd756e628c2c2571848
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.