Opened 18 months ago
Closed 17 months ago
#31990 closed enhancement (fixed)
ConvexSet_base: Add methods an_element, some_elements
| Reported by: | Matthias Köppe | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-9.4 |
| Component: | geometry | Keywords: | |
| Cc: | gh-kliem, Travis Scrimshaw, Yuan Zhou | Merged in: | |
| Authors: | Matthias Koeppe | Reviewers: | Travis Scrimshaw |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 1744ffa (Commits, GitHub, GitLab) | Commit: | 1744ffadb775f6a9f975f07f858a22f19c5efc8b |
| Dependencies: | #31959 | Stopgaps: |
Status badges
Description
Although subclasses of ConvexSet_base are not necessarily Parents, it will be useful for them to provide an_element and some_elements methods.
Change History (14)
comment:1 Changed 18 months ago by
| Dependencies: | → #31959 |
|---|
comment:2 Changed 18 months ago by
| Branch: | → u/mkoeppe/convexset_base__add_methods_an_element__some_elements |
|---|
comment:3 Changed 18 months ago by
| Authors: | → Matthias Koeppe |
|---|---|
| Commit: | → a8845171bcb84207ef8b56a139067f809ad7a675 |
| Status: | new → needs_review |
comment:4 Changed 18 months ago by
| Commit: | a8845171bcb84207ef8b56a139067f809ad7a675 → b19b3cc61cb8f0aed9a1f80accca1f5025da06f4 |
|---|
comment:5 Changed 18 months ago by
| Reviewers: | → Travis Scrimshaw |
|---|
The only little quip I have is that generally in Sage some_elements() returns a list rather than an iterable. It might be good to be consistent about this.
comment:6 Changed 18 months ago by
| Commit: | b19b3cc61cb8f0aed9a1f80accca1f5025da06f4 → ed898e6b23488a2912cb510ef1d7d59a798d51a7 |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| f0e7c58 | ambient_vector_space docstring: Fix bad blocks
|
| 200d967 | ConvexSet_base.ambient doctest: Actually test the method
|
| 1c2bef5 | Merge #31959
|
| ed898e6 | ConvexSet_base.an_element, some_elements: Go through generator method _some_elements_, make some_elements return a list
|
comment:7 Changed 18 months ago by
| Status: | needs_review → needs_work |
|---|
comment:8 Changed 18 months ago by
| Commit: | ed898e6b23488a2912cb510ef1d7d59a798d51a7 → 7152e1fdcdf6de646218a459870e1bbb885337af |
|---|
comment:9 Changed 18 months ago by
| Status: | needs_work → needs_review |
|---|
comment:11 Changed 18 months ago by
| Commit: | 7152e1fdcdf6de646218a459870e1bbb885337af → 1744ffadb775f6a9f975f07f858a22f19c5efc8b |
|---|
comment:12 Changed 18 months ago by
| Status: | needs_review → positive_review |
|---|
Patchbot is green modulo the unrelated sage.misc.package test failure.
Merged latest #31959 to get rid of pyflakes' report on an unused import.
comment:14 Changed 17 months ago by
| Branch: | u/mkoeppe/convexset_base__add_methods_an_element__some_elements → 1744ffadb775f6a9f975f07f858a22f19c5efc8b |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Last 10 new commits:
RelativeInterior.is_universe: NewPolyhedron_base.interior: Handle the empty polyhedron correctlyPolyhedron_base.product: Add doctest for alias 'cartesian_product'Merge #31919ConvexSet_base._test_contains: Only test extension to AA for exact base ringsRelativeInterior.ambient, ambient_vector_space, is_universe: NewConvexSet_base: Add default implementations of ambient, ambient_dim; add doctestsMerge #31959ConvexSet_base.{an_element,some_elements}, Polyhedron.some_elements, RelativeInterior.some_elements: NewPolyhedronFace.some_elements: New