Changes between Initial Version and Version 1 of Ticket #31984


Ignore:
Timestamp:
Jun 16, 2021, 2:04:40 PM (18 months ago)
Author:
Dave Morris
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #31984 – Description

    initial v1  
    1 The C++ function `std::abs` can overflow, because the twos-complement binary representation has a negative number (all 1s) whose negative requires an additional bit. Some bugs resulting from this are fixed in #31585, but the other occurrences of `std::abs` in the pynac source code should also be examined, to determine whether they are also buggy.
     1The C++ function `std::abs` can overflow, because the twos-complement binary representation has a negative number (`-2^k`, where `k + 1` is the number of bits) whose negative requires an additional bit. Some bugs resulting from this are fixed in #31585, but the other occurrences of `std::abs` in the pynac source code should also be examined, to determine whether they are also buggy.
    22
    33(There is one other occurrence of `std::abs` in numeric.cpp, and several in inifcns_nstdsums.cpp.)